Repository navigation
Fix setvaluestring ptr compare - #1132
Open
kanishk25249-sudo wants to merge 2 commits into
Open
kanishk25249-sudo wants to merge 2 commits into
kanishk25249-sudo wants to merge 2 commits into
Conversation
Author
|
I've opened a PR for this: #1106. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1106.
The previous implementation compared unrelated pointers using relational operators (<), which results in undefined behavior in C.
This PR replaces the pointer comparison with a strings_overlap() helper that uses pointer equality checks to detect overlapping memory regions.
The existing behavior is preserved: cJSON_SetValuestring() still returns NULL when the source and destination strings overlap.
The helper introduces O(length) additional time complexity, which is the same order as the existing strlen() calls.