Repository navigation
Fix: avoid strict-aliasing violation in parse_number - #1131
Open
YikunWei-dev wants to merge 1 commit into
Open
YikunWei-dev wants to merge 1 commit into
YikunWei-dev wants to merge 1 commit into
Conversation
In parse_number, strtod's end pointer was obtained by casting (unsigned char **) to (char **) and writing through it, which is a strict-aliasing violation (undefined behavior). Use an intermediate char* variable and assign it back to after_end instead. No behavior change; verified cJSON.c still compiles and the existing parse_number tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In parse_number, strtod's end pointer was obtained by casting (unsigned char **) to (char *) and writing through it, which is a strict-aliasing violation (undefined behavior). Use an intermediate char variable and assign it back to after_end instead.
No behavior change; verified cJSON.c still compiles and the existing parse_number tests pass.