Repository navigation
Fix: reject invalid \uXXXX escape sequences - #1130
Open
YikunWei-dev wants to merge 1 commit into
Open
YikunWei-dev wants to merge 1 commit into
YikunWei-dev wants to merge 1 commit into
Conversation
parse_hex4() returned 0 for both a valid U+0000 and an invalid hex sequence, so callers could not tell them apart. As a result, an invalid escape like "\uGGGG" was silently accepted and decoded into a single NUL byte instead of failing the parse. Add an int *ok output parameter to parse_hex4() and make utf16_literal_to_utf8() fail when the hex digits are invalid. Update tests and add coverage for invalid escapes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_hex4() returned 0 for both a valid U+0000 and an invalid hex sequence, so callers could not tell them apart. As a result, an invalid escape like "\uGGGG" was silently accepted and decoded into a single NUL byte instead of failing the parse.
Add an int *ok output parameter to parse_hex4() and make utf16_literal_to_utf8() fail when the hex digits are invalid. Update tests and add coverage for invalid escapes.