Repository navigation
Conversation
cJSON_Print(), cJSON_PrintUnformatted() and cJSON_PrintBuffered() escape each control character as a 6-byte \uXXXX sequence and grow the output buffer without an upper bound, so a string of N control characters prints as about 6N bytes. On memory-constrained targets this can exhaust the heap. Add an optional compile-time limit, following CJSON_NESTING_LIMIT: - CJSON_PRINT_LIMIT (default 0 = no limit, so behaviour is unchanged). - ensure() refuses to grow an allocating print buffer beyond the limit and caps the doubling growth at the limit; the print functions then return NULL and free their buffer. - cJSON_PrintPreallocated() is unaffected; it is bounded by the caller's buffer. - New tests in tests/print_limit.c. CVE-2026-39148 Reported by Rachid Marcil (gsmarcil).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cJSON_Print(), cJSON_PrintUnformatted() and cJSON_PrintBuffered() escape each control character as a 6-byte \uXXXX sequence and grow the output buffer without an upper bound, so a string of N control characters prints as about 6N bytes. On memory-constrained targets this can exhaust the heap.
Add an optional compile-time limit, following CJSON_NESTING_LIMIT:
CVE-2026-39148
Reported by Rachid Marcil (gsmarcil).