Repository navigation
Attach modifiable-config agent alongside JaCoCo - #13150
Draft
AlexeyKuznetsov-DD wants to merge 1 commit into
Draft
AlexeyKuznetsov-DD wants to merge 1 commit into
AlexeyKuznetsov-DD wants to merge 1 commit into
Conversation
The JaCoCo coverage agent was treated as a foreign -javaagent, so the modifiable-config agent was never attached to tests with coverage enabled. Spock modules masked this through ConfigTransformSpockExtension. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Attaches the modifiable-config test agent to test JVMs that also run the JaCoCo coverage agent.
Motivation
The plugin skips attaching when another
-javaagentis already present, and it counted JaCoCo as one. So modules with coverage enabled never got the agent, andConfig/InstrumenterConfigstayed unmodifiable at load time. Spock modules hid this becauseConfigTransformSpockExtensionrewritesConfigat runtime. Modules with no Spock, such asinternal-apionce its Groovy is removed, fail with "Config/InstrumenterConfig INSTANCE fields are not modifiable".Additional Notes
This affects every module's tests, so it is a separate PR.
:communication:test(Spock + JUnit, 297 tests) passes with both agents attached.#13152 (Groovy cleanup for
internal-api) is stacked on this one.Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issue🤖 Generated with Claude Code