Skip to content

Attach modifiable-config agent alongside JaCoCo - #13150

Draft
AlexeyKuznetsov-DD wants to merge 1 commit into
masterfrom
alexeyk/modifiable-config-with-jacoco
Draft

AlexeyKuznetsov-DD wants to merge 1 commit into
masterfrom
alexeyk/modifiable-config-with-jacoco

Conversation

@AlexeyKuznetsov-DD

@AlexeyKuznetsov-DD AlexeyKuznetsov-DD commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

What Does This Do

Attaches the modifiable-config test agent to test JVMs that also run the JaCoCo coverage agent.

Motivation

The plugin skips attaching when another -javaagent is already present, and it counted JaCoCo as one. So modules with coverage enabled never got the agent, and Config / InstrumenterConfig stayed unmodifiable at load time. Spock modules hid this because ConfigTransformSpockExtension rewrites Config at runtime. Modules with no Spock, such as internal-api once its Groovy is removed, fail with "Config/InstrumenterConfig INSTANCE fields are not modifiable".

Additional Notes

This affects every module's tests, so it is a separate PR. :communication:test (Spock + JUnit, 297 tests) passes with both agents attached.

#13152 (Groovy cleanup for internal-api) is stacked on this one.

Contributor Checklist

🤖 Generated with Claude Code

The JaCoCo coverage agent was treated as a foreign -javaagent, so the
modifiable-config agent was never attached to tests with coverage enabled.
Spock modules masked this through ConfigTransformSpockExtension.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AlexeyKuznetsov-DD AlexeyKuznetsov-DD added type: bug fix Bug fix comp: testing Testing tag: no release notes Changes to exclude from release notes tag: ai generated Largely based on code generated by an AI or LLM labels Nov 1, 2026
@datadog-prod-us1-4

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.01 s 13.99 s [-0.6%; +0.9%] (no difference)
startup:insecure-bank:tracing:Agent 12.91 s 12.92 s [-0.7%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 17.88 s 17.70 s [+0.2%; +1.9%] (maybe worse)
startup:petclinic:iast:Agent 17.55 s 17.78 s [-2.2%; -0.4%] (maybe better)
startup:petclinic:profiling:Agent 17.67 s 17.57 s [-0.6%; +1.8%] (no difference)
startup:petclinic:sca:Agent 17.77 s 17.59 s [+0.1%; +1.9%] (maybe worse)
startup:petclinic:tracing:Agent 16.77 s 16.80 s [-1.2%; +0.9%] (no difference)

Commit: 852015fe · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant