Repository navigation
CI fixes: Python tests workflow, CVMFS deploy scope, latent dirac-install.py bug - #75
Merged
Merged
Conversation
- pythontests.yml used actions/setup-python@v1 with Python 3.8, which current runners no longer provide: bump to setup-python@v5 with Python 3.11 (and checkout@v6), and run the HS23 table generator tests. - deploy-cvmfs.yml ran on every branch push and always fails with the expired robot certificate; it fetches globalDefaults.cfg from master unconditionally, so deploying from a PR branch is meaningless: restrict the push trigger to master (weekly schedule unchanged).
- The pylint step downloaded DIRAC's .pylintrc, which no longer exists (pylint configuration moved to pyproject.toml): lint with pylint's error-only defaults instead. - pylint 4 flagged E0606 in writeDefaultConfiguration(): releaseConfig is assigned inside loadConfiguration() without a global statement, so writeDefaultConfiguration() raises NameError when reached. Bind it globally and initialize it to None at module level.
fstagni
force-pushed
the
ci-management-fixes
branch
from
November 9, 2026 12:50
c39a4af to
f8f7def
Compare
fstagni
force-pushed
the
hs23-table-generator
branch
from
November 9, 2026 12:51
7aa4049 to
1fd2c16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI fixes: Python tests workflow, CVMFS deploy scope, latent
dirac-install.pybugBase of the stack — merge this PR first, then #74 (the HS23 table generator), which builds on it.
Two commits:
1. Fix the Python tests workflow, scope the CVMFS deploy to master (0fea500)
pythontests.ymlusedactions/setup-python@v1with Python 3.8, which current runners no longer provide ("Version 3.8 with arch x64 not found") — the workflow has been broken for every push/PR. Bumped tocheckout@v6+setup-python@v5+ Python 3.11.deploy-cvmfs.ymlran on every branch push and always fails with the robot certificate expired in 2022; it fetchesglobalDefaults.cfgfrommasterunconditionally, so deploying from a PR branch is meaningless. Push trigger restricted tomaster(weekly schedule unchanged). Renewing the certificate remains an infra task outside this PR.2. Fix the pylint step and a latent
NameErrorindirac-install.py(c39a4af).pylintrc, which no longer exists (configuration moved topyproject.toml) — the curl saved a "404: Not Found" body and pylint failed to parse it. Lint with pylint's error-only defaults instead, covering bothdirac-install.pyand the HS23 table generator.writeDefaultConfiguration():releaseConfigis assigned insideloadConfiguration()without aglobalstatement, sowriteDefaultConfiguration()raisesNameErrorwhen reached (verified in isolation). Fixed withglobal releaseConfigat the top ofloadConfiguration()and a module-levelreleaseConfig = None.Evidence
flake8 --select=E9,F63,F7,F82clean,pylint -Eclean on both files, 7 generator tests pass.Merge Danger
Door: two-way — workflow configuration and one-line bug fix; revertible independently of #74's content (but merge order matters for the workflow's generator steps).
Blast Radius: CI only, plus the long-broken
dirac-install.pyend-of-install path.