Repository navigation
ci: use github token with release-please - #41
Merged
Merged
Conversation
Drop MY_RELEASE_PLEASE_TOKEN, a long-lived token readable from any branch that could push tags and therefore publish to PyPI. release-please now runs as the first job of deployment.yml with the job token, and the build/publish jobs run when it reports release_created, building the new tag (hatch-vcs unchanged). This is the layout diracx-web already uses: a single workflow, because nothing done with GITHUB_TOKEN (including the release tag) starts another workflow. The workflow now only runs on pushes to the default branch, so the pypi environment must allow that branch instead of v* tags. Assisted-by: Claude:claude-opus-5-5
- concurrency group so two quick merges cannot race to create the same release (queued runs are kept, one may wait on pypi approval) - workflow_dispatch with a tag input to rebuild and publish an existing release when the publish failed after the release was created - drop the explicit token input (it is the action's default) - install only build and readme_renderer; python -m build gets hatchling and hatch-vcs from build-system.requires in its isolated env - rename the workflow to "Release"; it now runs on every push to main Assisted-by: Claude:claude-opus-5-5
Assisted-by: Claude:claude-opus-5-5
This was referenced Nov 11, 2026
fstagni
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.