Repository navigation
Conversation
…irements dirac-wms-cpu-normalization may no longer print a DB12 'Estimated CPU power' line (DB12 can be disabled via Operations/JobScheduling/RunDB12Benchmark, leaving only the HS23 table lookup). Parse the factor defensively, pass --CPUNormalizationFactor only when available, and fall back to expressing the queue length in wall-clock seconds otherwise.
fstagni
force-pushed
the
feat/hs23-cpu-normalization
branch
from
November 9, 2026 08:38
5748301 to
f65cf0e
Compare
fstagni
marked this pull request as ready for review
November 9, 2026 14:17
fstagni
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature: tolerate a missing CPU normalization factor in
ConfigureCPURequirementsPart of DIRACGrid/DIRAC#8871. Companion pilot change for DIRACGrid/DIRAC#8870.
Summary
Companion to DIRACGrid/DIRAC#8870 (CPU power from the HEPiX HS23 table). Once DB12 can be disabled (
Operations/JobScheduling/RunDB12Benchmark=False),dirac-wms-cpu-normalizationmay no longer print theEstimated CPU power is X HS06line, and the pilot command would crash with an unboundcpuNormalizationFactor.Parsing is also hardened: a missing
CPU time left determined asline now exits with a clear error instead of raisingNameError.Evidence
python -m py_compile Pilot/pilotCommands.pypasses.jobCPUReqcomputation); only the previously-crashing absent-factor path changed.Merge Danger
Door: two-way — with the DIRAC default configuration (unit
DB12) the DB12 line is always printed and the code path is unchanged.Blast Radius: pilot bootstrap only. To be merged after (or together with) DIRACGrid/DIRAC#8870; alone it is a no-op robustness fix.
CI: all fine at https://github.com/fstagni/Pilot/actions/runs/42587420596