Repository navigation
final_cat.param: keep per-branch NGMIX_G{1,2}_ERR - #1003
Merged
Merged
Conversation
make_cat writes NGMIX_G{1,2}_ERR for all five metacal branches, but the
data param had the 1M/1P/2M/2P lines commented out and the image-sims
params omitted them, so merged catalogues carried NOSHEAR errors only.
sp_validation's inverse-variance response needs each sheared branch's
own errors.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JK7o9EjzCX36De7Gx1gXL7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The merged v2 catalogue carries
NGMIX_G{1,2}_ERRfor NOSHEAR only, so the inverse-variance weight can't be evaluated on each metacal branch; sp_validation's IV response needs each sheared branch's own errors.make_catalready writes all ten columns into every per-tilefinal_cat-<tile>.hdf5. The column list applied at the campaign merge dropped eight of them: the 1M/1P/2M/2P lines were commented out inworkflow/config/cfis/final_cat.param(inherited from v1's#NGMIX_ELL_ERR_<shear>) and absent from both image-sims params. This PR lists them in all three.No reprocessing. Run-1's per-tile catalogues on Nibi already carry the columns (one tile checked per campaign, covering every code SHA in
latest/). The param change alters the merge's schema digest, so the nextfinal_cat_mergerebuilds the merged file in full from the existing tiles, with eight more float columns.Tests:
test_psf_grammar_properties,test_mask_ext_columns,test_zero_object_tile,test_final_cat_merge_invariants(41 passed).🤖 Generated with Claude Code
https://claude.ai/code/session_01JK7o9EjzCX36De7Gx1gXL7