Skip to content

final_cat.param: keep per-branch NGMIX_G{1,2}_ERR - #1003

Merged
cailmdaley merged 1 commit into
developfrom
fix/final-cat-sheared-ngmix-errors
Nov 15, 2026
Merged

cailmdaley merged 1 commit into
developfrom
fix/final-cat-sheared-ngmix-errors

Conversation

@cailmdaley

Copy link
Copy Markdown
Contributor

The merged v2 catalogue carries NGMIX_G{1,2}_ERR for NOSHEAR only, so the inverse-variance weight can't be evaluated on each metacal branch; sp_validation's IV response needs each sheared branch's own errors.

make_cat already writes all ten columns into every per-tile final_cat-<tile>.hdf5. The column list applied at the campaign merge dropped eight of them: the 1M/1P/2M/2P lines were commented out in workflow/config/cfis/final_cat.param (inherited from v1's #NGMIX_ELL_ERR_<shear>) and absent from both image-sims params. This PR lists them in all three.

No reprocessing. Run-1's per-tile catalogues on Nibi already carry the columns (one tile checked per campaign, covering every code SHA in latest/). The param change alters the merge's schema digest, so the next final_cat_merge rebuilds the merged file in full from the existing tiles, with eight more float columns.

Tests: test_psf_grammar_properties, test_mask_ext_columns, test_zero_object_tile, test_final_cat_merge_invariants (41 passed).

🤖 Generated with Claude Code

https://claude.ai/code/session_01JK7o9EjzCX36De7Gx1gXL7

make_cat writes NGMIX_G{1,2}_ERR for all five metacal branches, but the
data param had the 1M/1P/2M/2P lines commented out and the image-sims
params omitted them, so merged catalogues carried NOSHEAR errors only.
sp_validation's inverse-variance response needs each sheared branch's
own errors.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JK7o9EjzCX36De7Gx1gXL7
@cailmdaley
cailmdaley merged commit 85713b1 into develop Nov 15, 2026
2 checks passed
@cailmdaley
cailmdaley deleted the fix/final-cat-sheared-ngmix-errors branch November 15, 2026 21:32
@cailmdaley cailmdaley added the agent-merged Merged by an agent under the risk-tier policy, without human review label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-merged Merged by an agent under the risk-tier policy, without human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant