Skip to content

agent-computer: COMPUTER_BIND chooses the address a managed computer listens on #910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wcares wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −2
Open

agent-computer: COMPUTER_BIND chooses the address a managed computer listens on #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions agent-computer/src/browser-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export type BrowserRuntime = {
channel: "chromium" | "chrome";
mode: BrowserMode;
useVirtualDisplay: boolean;
hostname?: "127.0.0.1";
hostname?: string;
allowExec: boolean;
};

Expand All @@ -21,6 +21,9 @@ export function browserRuntimeFromEnv(
);
}
const local = backend === "local-chrome";
// Where the HTTP process listens. Native Chrome always listens on loopback. A managed computer listens on every interface unless COMPUTER_BIND names an address,
// so a computer that runs on a person's own machine (not in a container) can be kept off the network: COMPUTER_BIND=127.0.0.1.
const bind = env.COMPUTER_BIND?.trim();
/*
* Headed wherever a hosted computer runs, which is Linux: a container, a Kubernetes pod, the
* desktop app's Podman machine. Headless Chromium is the browser bot checks are best at spotting
Expand All @@ -45,7 +48,7 @@ export function browserRuntimeFromEnv(
channel: local ? "chrome" : "chromium",
mode,
useVirtualDisplay: platform === "linux" && mode === "headed",
...(local ? { hostname: "127.0.0.1" as const } : {}),
...(local ? { hostname: "127.0.0.1" } : bind ? { hostname: bind } : {}),
allowExec: !local,
};
}
10 changes: 10 additions & 0 deletions agent-computer/tests/browser-runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,16 @@ describe("the configured browser runtime", () => {
});
});

test("a managed computer listens on every interface unless COMPUTER_BIND names one", () => {
expect(browserRuntimeFromEnv({}, "linux").hostname).toBeUndefined();
expect(
browserRuntimeFromEnv({ COMPUTER_BIND: " 127.0.0.1 " }, "win32").hostname,
).toBe("127.0.0.1");
expect(
browserRuntimeFromEnv({ COMPUTER_BIND: "127.0.0.1" }, "win32").allowExec,
).toBe(true);
});

test.each(["darwin", "win32"])(
"managed %s, a developer's own machine, stays headless",
(platform) => {
Expand Down