Repository navigation
Conversation
Signed-off-by: kevin9327 <5299031+kevin9327@users.noreply.github.com>
kevin9327
requested review from
MikeRyanDev,
davidmckayv,
dustywusty,
guidovizoso,
mxmzb,
samjulien and
tylerslaton
as code owners
October 30, 2026 13:37
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
An approval shows what a Bot is about to do. Two cuts there sliced by UTF-16 units:
approvalPreviewinserver/src/approvals/types.tscuts a string argument longer than 2,000 units withargs.slice(0, 1999) + "…".clipinserver/src/delivery/opentag.tscuts each OpenTag approval field to 300 withtext.slice(0, max - 1) + "…".When the cut landed between the two halves of an emoji, the value ended in a lone high surrogate. The person approving then saw
�…, and the approval row stored a string that is not valid Unicode.Both now use
cutAtCodeUnitsfromchannels/text.ts, which the MCP, Google Drive, Composio, Arcade and routines result cuts already use. It drops the half character, so nothing gets longer than before. Secret masking runs on the cut text as before.Where it runs
Boundary and audit
Changelog
CHANGELOG.mdunderUnreleased; happy to rebase if it conflicts.Proof
New case in
server/tests/approvals.test.ts. On unmodifiedmain:With the change,
bun test tests/approvals.test.ts(18 pass) andtests/delivery-routes.test.ts(25 pass) pass.tsc --noEmitinserver/andbiome lint --error-on-warningson the changed files are clean.AI assistance: I used an AI coding assistant to find and write this change, and reviewed and tested it myself.