Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: Docs

on:
release:
types: [published]
push:
branches: [master]
workflow_dispatch:

permissions:
Expand Down
33 changes: 0 additions & 33 deletions .github/workflows/release-please.yml

This file was deleted.

1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
@conventioncatcorp:registry=https://npm.pkg.github.com
1 change: 0 additions & 1 deletion .release-please-manifest.json

This file was deleted.

2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ PolymorphicExtras<XOwnProps, T>` (spell `XOwnProps` out, or Storybook docgen los
- Use `import type` for types (`verbatimModuleSyntax`). Named React imports, no `import React` unless needed.
- Class names go through `mapToCssModules(classNames(...), cssModule)`.
- Bootstrap 5 only: don't add Bootstrap 4 classes/props back.
- Commits: Conventional Commits (release-please builds the changelog and releases from `master`).
- Commits: Conventional Commits. Releases are published locally (`npm version` + `npm publish`, see README); no CI release.

## Gotchas

Expand Down
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
# 10.0.0 (2026-11-10)

First release of `@conventioncatcorp/reactstrap`, the ConventionCatCorp fork. TypeScript, React 19 and Bootstrap 5
only, with typed polymorphic `tag`. Breaking changes and the upgrade guide are in [v10-migration.md](v10-migration.md).

# [9.0.0-8](https://github.com/reactstrap/reactstrap/compare/v9.0.0-7...v9.0.0-8) (2021-10-15)


Expand Down
11 changes: 10 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,16 @@ npm run build # dist/ (Vite lib build + tsc declarations)

## Releasing

Release branches/versioning/notes will be automatically created and maintained by the [release-please](https://github.com/googleapis/release-please) github action. When you're ready to publish the release, just merge the release branch. The release will be created, the package is published to GitHub Packages, and the docs are deployed to GitHub Pages.
Published from a local machine to GitHub Packages (`.npmrc` maps the `@conventioncatcorp` scope; your `~/.npmrc` needs
a token with `write:packages` for `//npm.pkg.github.com/`):

```sh
npm version <major|minor|patch> # bumps package.json, commits and tags
npm publish # prepublishOnly runs typecheck, lint, tests and build
git push --follow-tags
```

Storybook docs deploy to GitHub Pages on every push to `master`.

## In the wild

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@conventioncatcorp/reactstrap",
"version": "9.2.3",
"version": "10.0.0",
"description": "React 19 components for Bootstrap 5 (ConventionCatCorp fork of reactstrap)",
"type": "module",
"main": "./dist/index.js",
Expand Down Expand Up @@ -28,7 +28,7 @@
"cover": "vitest run --coverage",
"start": "storybook dev -p 8080",
"build:docs": "storybook build -o build",
"prepublishOnly": "npm run build"
"prepublishOnly": "npm run typecheck && npm run lint && npm run test:ci && npm run build"
},
"prettier": {
"singleQuote": true,
Expand Down
30 changes: 0 additions & 30 deletions release-please-config.json

This file was deleted.

16 changes: 7 additions & 9 deletions v10-migration.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ deprecation tests went with them. New regression tests cover the React 19 bugs l
- **CI** (`.github/workflows`):
- `ci.yml` replaces `test.yml` + `coverage.yml`. It runs on Node from `.nvmrc`: lint → format:check → typecheck →
cover → build → build:docs, then uploads to Coveralls.
- `release-please.yml` runs release-please v5 in manifest mode (`release-as: 10.0.0`) and publishes to GitHub Packages
with `GITHUB_TOKEN`.
- `docs.yml` deploys Storybook to GitHub Pages. This replaces `scripts/docs`, which pushed to the upstream
- No CI release: release-please is gone. Releases are published locally to GitHub Packages (`npm version`, then
`npm publish`); `prepublishOnly` runs typecheck, lint, tests and build first.
- `docs.yml` deploys Storybook to GitHub Pages on every push to `master`. This replaces `scripts/docs`, which pushed to the upstream
`reactstrap.github.io` repo.
- Actions: checkout v7, setup-node v7, upload-pages-artifact v5, deploy-pages v5.
- Dependabot covers npm and actions weekly, grouped.
Expand Down Expand Up @@ -196,12 +196,10 @@ prettier 3.9, storybook 10.6 (+ react-vite, addon-docs, addon-links), react / re
TooltipPopoverWrapper, UncontrolledDropdown.
- They are the riskiest to rewrite, and `PopperContent` must stay a class for the `defaultProps` patch.
- Converting them to hooks is a follow-up; it needs a replacement for that patch, e.g. a defaults context.
3. **GitHub Packages vs `npm.concat.app`.**
- ConCat's `.npmrc` maps `@conventioncatcorp` to GitHub Packages, so this repo publishes there.
- But the umzug fork's repo publishes `@concat/umzug` to `npm.concat.app`.
- Confirm which registry is canonical.
4. **Versioning.** `package.json` stays at 9.2.3. `release-please-config.json` sets `release-as: 10.0.0`; remove that
after the first release.
3. **Registry:** GitHub Packages (`@conventioncatcorp`), same as ConCat's `.npmrc`. The umzug fork's repo still names
`@concat/umzug` on `npm.concat.app`, so that repo looks out of date.
4. **ConCat `min-release-age=3`** stops npm from resolving versions younger than 3 days. Install a fresh release once
with `npm install --min-release-age=0` to update the lockfile; `npm ci` installs from the lockfile and is unaffected.
5. **Kept oddities:**
- `CarouselControl` renders `<a role="button">` without keyboard handling; Bootstrap 5 uses a `<button>`.
- `CarouselItem`/`CarouselCaption` don't forward extra attributes.
Expand Down
Loading