Skip to content

feat!: v10 — TypeScript, React 19, Vite, Vitest, oxlint - #1

Merged
SimonSchick merged 2 commits into
masterfrom
v10
Nov 11, 2026
Merged

SimonSchick merged 2 commits into
masterfrom
v10

Conversation

@SimonSchick

Copy link
Copy Markdown

Renovates the fork as @conventioncatcorp/reactstrap v10. Full report: v10-migration.md.

What

  • 100% TypeScript. .d.ts files are generated from the source and types/ is gone. The old 5.4k-line type test now compiles against the generated types.
  • React 19 only. prop-types is removed, and function components no longer rely on defaultProps, which React 19 ignores.
  • react-transition-group and react-popper are replaced by small internal modules: src/Transition.tsx and src/popper.tsx. Both libraries are broken on, or capped below, React 19.
  • Typed polymorphic tag. [key: string]: any is removed from every props type: <Button tag={Link} to="/"> is checked against Link's props, and typos fail to compile. Input attributes and events follow type (select and textarea).
  • Tooling:
    • Babel + webpack → Vite 8 lib mode (ESM only)
    • Jest → Vitest
    • ESLint → oxlint
    • Storybook 6 → 10 (Vite, native autodocs)
    • yarn → npm, on Node 26
  • CI: one ci.yml pipeline; release-please v5 publishes to GitHub Packages; docs deploy to GitHub Pages.
  • Removed Bootstrap 4 leftovers: CardDeck, CardColumns, Media, Row noGutters and DropdownMenu right. This fork targets Bootstrap 5 only.
  • ConCat's React 19 quirks are fixed:
    • Popover defaults are no longer lost.
    • PopperContent.defaultProps is public and typed.
    • The CarouselItem findDOMNode crash is gone.
  • About a dozen latent bugs fixed: ButtonToggle, innerRefs that never reached the DOM, props leaking into the DOM, ignored cssModule. The list is in the report.

Breaking

Package renamed, React >=19 peer, ESM only, removed components and props, stricter prop types. ConCat can install the package under an alias ("reactstrap": "npm:@conventioncatcorp/reactstrap@^10"). Type-checking ConCat against this build gives 62 errors in 40 files. Most are select/textarea handlers typed as <input> events, and 38 of those come from one type. The other 4 are real ConCat bugs. Details are under "Adopting in ConCat" in the report.

Open decisions

See the report. The registry question still needs an answer: @conventioncatcorp on GitHub Packages, while the umzug fork uses npm.concat.app.

Test plan

  • npm run typecheck: covers src, tests, stories and config
  • npm run lint: oxlint with --deny-warnings
  • npm run format:check
  • npm run cover: 844 tests in 86 files, 95.6% lines
  • npm run build: ESM dist/ plus .d.ts; externals are only react, react-dom, classnames and @popperjs/core
  • npm run build:docs: Storybook builds with props tables
  • ConCat frontend type-checked against the packed build (the errors listed above)
  • CI green on this PR
  • Manual Storybook smoke test (Modal, Dropdown, Tooltip/Popover, Carousel, Collapse)

🤖 Generated with Claude Code

Renovate the fork as @conventioncatcorp/reactstrap v10.

- 100% TypeScript; .d.ts generated from source (types/ removed)
- React 19 only; prop-types and function-component defaultProps removed
- react-transition-group and react-popper replaced by internal
  Transition / popper modules (both broken on React 19)
- Polymorphic `tag` typing; `[key: string]: any` removed from all props
- Input attributes/events follow `type` (select, textarea)
- Babel/webpack → Vite 8 (ESM-only dist), Jest → Vitest, ESLint → oxlint,
  Storybook 6 → 10, yarn → npm, Node 26
- CI rebuilt; publish to GitHub Packages; docs to GitHub Pages
- Bootstrap 4 leftovers removed (CardDeck, CardColumns, Media,
  Row noGutters, DropdownMenu right)
- Fixes ConCat's React 19 quirks (Popover defaults, typed
  PopperContent.defaultProps, CarouselItem findDOMNode crash)

See v10-migration.md for the full report.

BREAKING CHANGE: package renamed, React >=19 peer, ESM only, removed
components/props, stricter prop types. See v10-migration.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@SimonSchick
SimonSchick requested a review from Doridian November 11, 2026 03:35
@SimonSchick
SimonSchick merged commit 2df5be2 into master Nov 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants