Repository navigation
feat(display): EDM converter preference for the target of related displays - #4024
Open
emilioheredia-source wants to merge 1 commit into
Conversation
…plays EDM opens a related display in a new window, which the converter maps to a new tab. The new preference related_display_target selects tab (default, unchanged), window or standalone instead, written as for the target of an Open Display action. An unknown value logs a warning and keeps tab. Related displays with 'close display' set still replace the current display.
emilioheredia-source
force-pushed
the
display/edm-related-display-target
branch
from
November 15, 2026 17:07
6c6cfab to
fdddcfd
Compare
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Part of #3543, item 2 there.
EDM opens a related display in a new window, and the EDM converter maps that to a new tab. A new converter preference selects the target instead:
tab(default, unchanged),windoworstandalone, as for the target of an Open Display action.tab.As @rjwills28 pointed out in #3543, the OPI converter already maps these displays to windows; this gives the EDM converter the same choice.
Checklist
Testing:
RelatedDisplayTargetTest: reading the setting, the default target, and the standalone target, with a small EDM file that has a related display with and without "close display". EDM converter module tests pass.Documentation:
edm_converter_preferences.properties, which the preference listing of the docs is built from)