Skip to content

fix(display): a new tab from a standalone window opens in the main window - #4023

Open
emilioheredia-source wants to merge 1 commit into
ControlSystemStudio:masterfrom
emilioheredia-source:display/standalone-tab-to-main
Open

emilioheredia-source wants to merge 1 commit into
ControlSystemStudio:masterfrom
emilioheredia-source:display/standalone-tab-to-main

Conversation

@emilioheredia-source

Copy link
Copy Markdown

Part of #3543, option (a) there.

A standalone window shows no tabs. A display opened in a new tab from there, by an Open Display action or a Ctrl-click, went into the standalone window and covered the current display, with no way back to it.

Now the new tab opens in the main window, which is brought to the front, as for applications started from a standalone window. The standalone window stays as it was.

  • A named pane that exists is still used; a new named pane is split off the main window.
  • If the main window can't take the tab, for example because its pane is locked, the display opens in a new window.
  • Windows with tabs behave as before.

The change is in DockItemRepresentation.openPanel(). It also removes the trailing whitespace of one line in that file, which the pre-commit check asks for.

Checklist

  • Testing:
    • The feature has automated tests
    • Tests were run
    • StandaloneNewTabUI (TestFX): a new tab from a standalone window, from a normal window, and from a standalone window while the main window's pane is locked. The first and the last fail on master. The ui-tests profile currently runs no tests (failsafe 2.22.0 doesn't discover JUnit 5 tests with the current JUnit platform), so the test was run with surefire under Xvfb, together with the module tests.

…ndow

A standalone window never shows its tab bar. A display opened in a new
tab from there, by an action or a Ctrl-click, covered the current
display, and there was no way back to it. Open the new tab in the main
window instead and bring that window to the front, as is already done
for applications started from a standalone window. A named pane that
exists is still used; a new named pane is split off the main window.
When the main window can't take the tab, for example because its pane
is locked, open the display in a new window.
@sonarqubecloud

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants