Repository navigation
Placeholders read JSON without empty allowedTypes/deniedTypes - #50
Open
BuildCodelessly wants to merge 1 commit into
Open
BuildCodelessly wants to merge 1 commit into
BuildCodelessly wants to merge 1 commit into
Conversation
Layouts published before the merge with master left empty type lists out of placeholder JSON; master's reader required them, so republishing a project failed reading its published layouts (variance_node.g.dart: type 'Null' is not a subtype of type 'List<dynamic>'). Read a missing list as empty; writing and per-node defaults are unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013oMokUGNW6txknJs7xxTik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #45.
Layouts published from that branch before it merged with master left empty
allowedTypes/deniedTypesout of placeholder JSON. Master's reader requires both, so republishing such a project failed while reading its existing published layouts:This reads a missing list as empty (
@JsonKey(readValue: readTypesOrEmpty)). Writing is unchanged, and so are per-node defaults: a list view still denies nested lists.Checks
dart format: no changes.dart analyze --fatal-infos: no issues.dart test: all 379 pass, including the newtest/placeholder_types_missing_test.dart.site.publishto https://site.codelessly.com/crate-digger).Generated by Claude Code