Repository navigation
London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | Dead code - #1764
mandipsanger wants to merge 24 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Hi Mandip! 👋 Thanks for your work on this assignment. I noticed that GitHub is reporting a merge conflict on this PR. Could you please resolve the conflict with the main branch? Also, the automated check previously flagged Sprint-3/2-practice-tdd/count.js as an unexpected file for this assignment. Could you double-check the Files changed tab and make sure the PR only contains changes relevant to the Dead Code exercise? Once these are resolved, we can continue with the code review. Thanks, and keep up the good work! |
This comment has been minimized.
This comment has been minimized.
|
Thank you for checking. I have tried to replace this original file for over 3 weeks now. Also removed the auto formatting as you can see from the committs have replaced the original file many time but still it is not going through and not making changes. I tried to do with oleg in the workshop too but didnt get sucess. Is there any way you could help with this? It doesn't let me reslove conflicts and merge changes. Does it mean I have to make a new branch and new PR? |
|
Hi @mandipsanger, Apologies for the delayed response. I appreciate the effort you've put into trying to resolve this over the past few weeks. I've checked your PR again, and the You don't necessarily need to create a new branch or PR yet. I'm happy to help you troubleshoot this. Could you please run the following commands in your terminal and share the output? git status
git branch --show-current
git remote -vThis will help us understand the current state of your repository and determine the safest way to resolve the issue without losing your completed exercises. If necessary, we can create a clean branch from the latest main branch and transfer only your Dead Code changes. Thanks for your persistence, and well done for reaching out for help! |
Export countChar function for external use.

Learners, PR Template
Self checklist
Task code
CYF-1066
Changelist
Deadcode