Skip to content

Manchester | 26-ITP-Sept | Aklilu Tsehaye | Sprint 3 | Build a quote generator app - #1564

Open
AkliluMihtsun wants to merge 4 commits into
CodeYourFuture:mainfrom
AkliluMihtsun:coursework/Sprint-3-quote-generator
Open

AkliluMihtsun wants to merge 4 commits into
CodeYourFuture:mainfrom
AkliluMihtsun:coursework/Sprint-3-quote-generator

Conversation

@AkliluMihtsun

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1096

Changelist

I have created the quote generator app

@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2026
Comment on lines +8 to +10
width: 70%;
margin: 150px auto;
padding: 60px;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On a narrow phone viewport, what width does this container occupy after its 60px padding is added on each side?

To "like" or "dislike" this comment, please follow this link

@cyf-ai-code-reviewer cyf-ai-code-reviewer Bot added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 21, 2026
@cyf-ai-code-reviewer

Copy link
Copy Markdown

The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look.

@AkliluMihtsun AkliluMihtsun added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 21, 2026
@jimoholayinka01 jimoholayinka01 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 22, 2026
@jimoholayinka01

Copy link
Copy Markdown

Hi @AkliluMihtsun I have checked your quote generator app locally and it is well designed. The styling made it look more decent. Your code commits clean and everything works fine on first attempt. Well done, I will be marking this as completed.
image

@jimoholayinka01 jimoholayinka01 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants