Repository navigation
Manchester | 26-ITP-Sept | Aklilu Tsehaye | Sprint 3 | Build a quote generator app - #1564
Open
AkliluMihtsun wants to merge 4 commits into
Open
AkliluMihtsun wants to merge 4 commits into
AkliluMihtsun wants to merge 4 commits into
Conversation
Comment on lines
+8
to
+10
| width: 70%; | ||
| margin: 150px auto; | ||
| padding: 60px; |
There was a problem hiding this comment.
On a narrow phone viewport, what width does this container occupy after its 60px padding is added on each side?
To "like" or "dislike" this comment, please follow this link
|
The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look. |
|
Hi @AkliluMihtsun I have checked your quote generator app locally and it is well designed. The styling made it look more decent. Your code commits clean and everything works fine on first attempt. Well done, I will be marking this as completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Learners, PR Template
Self checklist
Task code
CYF-1096
Changelist
I have created the quote generator app