Skip to content

London | 26-ITP-Sep | Shirin Panahian | Sprint 3| Build a quote generator app - #1561

Open
shirinpanahian wants to merge 3 commits into
CodeYourFuture:mainfrom
shirinpanahian:quote-generator
Open

shirinpanahian wants to merge 3 commits into
CodeYourFuture:mainfrom
shirinpanahian:quote-generator

Conversation

@shirinpanahian

@shirinpanahian shirinpanahian commented Nov 20, 2026 •

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1096

Changelist

  • Built a random quote generator app that displays a random quote.
  • Implemented the functionality to generate and display new quotes.
  • Improved the user interface with styling and layout enhancements.
  • Made the app more user-friendly and visually appealing.

@github-actions

This comment has been minimized.

@shirinpanahian shirinpanahian added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 3 Assigned during Sprint 3 of this module labels Nov 20, 2026
Comment thread Sprint-3/quote-generator/style.css Outdated
padding: 30px;
display: flex;
flex-direction: column;
width: 600px;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The card has a 600px content width plus 60px of horizontal padding. What happens to the layout on a phone-sized viewport?

To "like" or "dislike" this comment, please follow this link

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've fixed the responsiveness issue by changing the card's width to 100% and adding a max-width: 600px. I've also used box-sizing: border-box to ensure the padding is included in the total width. This allows the card to fit smaller screens without causing horizontal overflow.

@cyf-ai-code-reviewer cyf-ai-code-reviewer Bot added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 20, 2026
@cyf-ai-code-reviewer

Copy link
Copy Markdown

The CYF AI review has left comments. It will only review a PR one time. When you have addressed these comments, please request review again and a volunteer will take a look.

@shirinpanahian shirinpanahian added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 20, 2026
@jimoholayinka01

Copy link
Copy Markdown

Well done @shirinpanahian. One more thing before I can mark as completed, the instructions says on load of the page an advice should be generated but that's not the case with your code. Add that to your code cleanly and I will mark as completed.
image

@jimoholayinka01 jimoholayinka01 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants