Skip to content

Manchester | 26-ITP-Sep | Rahana Suleiman| Sprint 3 | Module-Data-Groups: Quote-Generator - #1540

Open
rahanasuleiman8-ship-it wants to merge 6 commits into
CodeYourFuture:mainfrom
rahanasuleiman8-ship-it:sprint-3-quote-generator
Open

rahanasuleiman8-ship-it wants to merge 6 commits into
CodeYourFuture:mainfrom
rahanasuleiman8-ship-it:sprint-3-quote-generator

Conversation

@rahanasuleiman8-ship-it

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1096

Changelist

Implemented a random quote generator that displays a random quote and its author on initial page load and updates both with a new random quote whenever the "New quote" button is clicked.

@rahanasuleiman8-ship-it rahanasuleiman8-ship-it added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Nov 17, 2026
@cyf-ai-code-reviewer

Copy link
Copy Markdown

The CYF AI reviewer checked this PR did not find any obvious problems. Please wait for a volunteer to also have a look and offer their own feedback.

@jimoholayinka01 jimoholayinka01 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 18, 2026
@jimoholayinka01

Copy link
Copy Markdown

Great job building the quote generator. I would like you to customise the app a bit further. Update the title element in index.html to "Quote generator app". Customise, the html page, add some time to automate the advice without having to click the button. It can look however you like but there is an example in the folder at quote_generator_example.png. I have attached how your current index.html looks like.
image

@jimoholayinka01 jimoholayinka01 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Nov 18, 2026
@rahanasuleiman8-ship-it

Copy link
Copy Markdown
Author

Hi @jimoholayinka01, thanks for the review feedback! I've updated the <title> in index.html to "Quote generator app", customised the layout and styling in style.css, and added an automatic timer to cycle quotes while resetting cleanly when clicking New quote. Everything passes tests and is pushed to the branch—let me know if you'd like any further changes!

@rahanasuleiman8-ship-it rahanasuleiman8-ship-it added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Nov 21, 2026
@jimoholayinka01

Copy link
Copy Markdown

Hi @rahanasuleiman8-ship-it thank you for editing the code and including the suggested changes. I have checked locally, your code are clean, timer worked well and it is well styled. Well done. I will now be marking this as completed.

@jimoholayinka01 jimoholayinka01 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Nov 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants