Repository navigation
Manchester | 26-ITP-Sep | Rahana Suleiman| Sprint 3 | Module-Data-Groups: Quote-Generator - #1540
Open
rahanasuleiman8-ship-it wants to merge 6 commits into
Conversation
|
The CYF AI reviewer checked this PR did not find any obvious problems. Please wait for a volunteer to also have a look and offer their own feedback. |
Author
|
Hi @jimoholayinka01, thanks for the review feedback! I've updated the <title> in index.html to "Quote generator app", customised the layout and styling in style.css, and added an automatic timer to cycle quotes while resetting cleanly when clicking New quote. Everything passes tests and is pushed to the branch—let me know if you'd like any further changes! |
|
Hi @rahanasuleiman8-ship-it thank you for editing the code and including the suggested changes. I have checked locally, your code are clean, timer worked well and it is well styled. Well done. I will now be marking this as completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Self checklist
Task code
CYF-1096
Changelist
Implemented a random quote generator that displays a random quote and its author on initial page load and updates both with a new random quote whenever the "New quote" button is clicked.