Repository navigation
feat: ask CodeBoarding for the pull request's review guide (experimental) - #160
Draft
Svilen-Stefanov wants to merge 1 commit into
Draft
Svilen-Stefanov wants to merge 1 commit into
Svilen-Stefanov wants to merge 1 commit into
Conversation
…tal) When `review_guide_url` is set, a review run packs what it already has (both analyses, both call graphs from the static_analysis.pkl beside them, the diff between the two analysed commits, and the changed files at both) into a gzipped bundle, posts it to the closed-functions service, and stores the answer in the review artifact as review_guide.json, where the platform reads it. It authenticates the way the hosted proxy does (a fresh OIDC token plus the license, minted by oidc_relay), or with the run's GITHUB_TOKEN when the workflow cannot mint one; a run with its own Ollama, OpenRouter or OpenAI key sends that key along. Off by default, and it never fails the run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
CodeBoarding reviewStatus: 1 changed component See the full change in CodeBoarding. graph LR
n_action_support_scripts["action_support_scripts"]
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_action_support_scripts modified;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
An experimental step that asks CodeBoarding for the pull request's review guide and stores it in the review artifact. It's off unless the workflow sets the new
review_guide_urlinput.After the review analysis,
scripts/review_guide.py:analysis.jsonfiles;static_analysis.pklbeside each, so nothing is recomputed;review_guide.json, before the upload. The webview reads it from there (webview #255). The webview never calls the service.Credentials follow the analysis:
oidc_relay.py, the same bearer the hosted proxy gets. The run'sGITHUB_TOKENstands in when the workflow can't mint one.Never fails the run: a refusal, a timeout or a bundle over the service's limit leaves the artifact without a guide and logs one line.
The guide's code isn't in this repository; only the bundling is.
Not done yet
v1: turning it on for everyone means a default URL once the service is in prod.Changes nothing visible by itself. Tests: 7 new (
tests/test_review_guide.py), all passing with the existing suite; Black clean.🤖 Generated with Claude Code