Repository navigation
refactor: share setup preview environment - #159
Open
ivanmilevtues wants to merge 1 commit into
Open
ivanmilevtues wants to merge 1 commit into
ivanmilevtues wants to merge 1 commit into
Conversation
Keep separate analysis and upload steps while defining their common environment once through a composite-compatible JSON step output. Amp-Thread-ID: https://ampcode.com/threads/T-01a1836f-dd66-7523-8dfe-445e32623212 Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
CodeBoarding reviewStatus: 0 changed components (no analysed file changed) See the full change in CodeBoarding. Compared against the merge base: this branch is 1 commit behind graph LR
n_action_support_scripts["action_support_scripts"]
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Addresses Svilen's duplication comment on merged PR #152. Based on latest origin/main, including the 1.17.0 release.
Change
Define the 14 shared preview environment bindings once, serialize them into a same-job step output, and consume them with
fromJSONin each preview. Keep the three explicit analysis/upload pairs: their distinct artifacts, conditions, per-step failure isolation, and the notification between the first and second previews are unchanged.MAX_PREVIEWSstays 3; incremental analysis is untouched.KEEP_AUTH=trueis command-scoped on previews 1 and 2; preview 3 and the existingalways()cleanup retain their behavior. Provider credentials remain in the existing auth files, not this output. No environment is exported into the caller'sGITHUB_ENV.This deliberately uses supported composite step environment expressions rather than YAML anchors: the runner's action YAML reader rejects anchors, while its step environment converter accepts expressions. Upload boilerplate remains because separate upload steps preserve existing artifact semantics.
Verification
python -m unittest discover -s tests -v: 273 tests ran, OK, 7 skipped (pinned engine not installed locally).git diff --checkpassed.Limitations: local tests do not execute GitHub's composite expression evaluator, real artifact service, email notification delivery, or live LLM analysis. Normal PR CI also does not exercise the setup-branch-only preview path end to end. Engine compatibility is delegated to existing CI.