Repository navigation
ci: control for samply fix, runner built from main (do not merge) - #145
Closed
GuillaumeLagrange wants to merge 9 commits into
Closed
GuillaumeLagrange wants to merge 9 commits into
GuillaumeLagrange wants to merge 9 commits into
Conversation
pytest 9.2 replaced the private `FixtureManager._arg2fixturedefs` with `_arg2node2fixturedefs` (pytest-dev/pytest#14984). The `pytest_plugin_registered` hook wrote into `_arg2fixturedefs` to swap pytest-benchmark's `benchmark` fixture for ours, so every `--codspeed` run with pytest-benchmark installed crashed with an AttributeError. On pytest 9.1+, register the override through the public `pytest.register_fixture` API at session start instead. Older pytest keeps the previous `_arg2fixturedefs` swap. pytest-benchmark itself still reads the removed `Node._nodeid` on pytest 9.2, so the two tests that run it without `--codspeed` are marked as non-strict xfail on that combination. Co-Authored-By: Guillaume Lagrange <19265358+GuillaumeLagrange@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…chmark The matrix only installed the latest pytest, so the fixture override paths for pytest without register_fixture (9.0) and before 8.1.1 were never exercised. Add pytest 9.0 and 8.0 jobs on Python 3.15 only, to avoid the full combinatorial matrix. The valgrind install condition matched a "pytest-benchmark" config that no longer exists since the split into -4 and -5, so the valgrind tests running --codspeed with pytest-benchmark installed were always skipped. Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
Closing throwaway debug PR (COD-4043). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Control for #142: PR #141 code with an unpatched runner built from source. Refs COD-4043