Skip to content

Change default port in application.properties - #238

Open
lcaouen wants to merge 1 commit into
ChannelFinder:masterfrom
lcaouen:change_default_port
Open

lcaouen wants to merge 1 commit into
ChannelFinder:masterfrom
lcaouen:change_default_port

Conversation

@lcaouen

@lcaouen lcaouen commented Nov 3, 2026

Copy link
Copy Markdown

As discussed during the codeathon, change default port in application.properties

@sonarqubecloud

sonarqubecloud Bot commented Nov 3, 2026

Copy link
Copy Markdown

@lcaouen

lcaouen commented Nov 3, 2026

Copy link
Copy Markdown
Author

CI fails but it does not seem to be linked to my PR. It seems a docker image is missing.
@jacomago maybe you can help me to find the problem

@jacomago

jacomago commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Why are we changing the default port? Seems dangerous? The default that spring boot would use is random.

@jacomago

jacomago commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

CI fails but it does not seem to be linked to my PR. It seems a docker image is missing. @jacomago maybe you can help me to find the problem

You need to update the port in the tests that use docker

public static final String HTTP_IP_PORT_CHANNELFINDER = "http://127.0.0.1:8080/ChannelFinder";

Which emphasizes my problem, this is not a backwards compatible change. I will have to update the deployment scripts in ESS after this change. Its not hard to overrite the port so I'm not sure the need to change it.

@lcaouen

lcaouen commented Nov 4, 2026

Copy link
Copy Markdown
Author

At CEA, we do a lot of installations and we usually install all the Phoebus services on the same computer which means we have to change the default port (8080) for all the services if we don't want to have a conflict.

If it is a problem to change the default port in Channel Finder, we can cancel this change and return to the 8080 default port.
In that case, I will also cancel the PR for the other services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants