Repository navigation
Add 1password-cli Feature - #16
Open
ghughes610 wants to merge 1 commit into
Open
ghughes610 wants to merge 1 commit into
ghughes610 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human PR description:
Ben Wilson has changed the way developers will interact with
qrsensor_vertiv_production. We use to use api keys that were shared/stored in our 1password. The issue became some keys leaked into theqrsensor_vertiv_production.On 11/10/26 Ben Wilson created a way for the devs to interact with that repo in a safer way (Dave Thomas is working on an elixir rebuild currently called QRS). In the meantime, we are going to start using personal access tokens generated by the app.qrsensor.com system. The changes can be seen here:
https://github.com/CargoSense/qrsensor_vertiv_production/pull/47
https://github.com/CargoSense/qrsensor_vertiv_production/pull/63
My understanding (very superficial) of the way these repos (devcontainers-features + workspace) interact is that when the workspace dev container builds it looks at the
devcontainers-featuresrepo to see which install script to run. This is why we need two PRs for this.I to test this I included the automated test but I also did all of this locally paired with Bens changes and the script he created worked.
Here is the second PR for workspace. (https://github.com/CargoSense/workspace/pull/90)
🧗 Generated by Greg Hughes
Robot PR description is below because this is all very new to me.
Adds a
1password-cliFeature that installs the 1Password CLI (op) into a dev container:Why
Some of our dev containers need
opto run scripts that read or store credentials in 1Password. Publishing it here means any container gets it with one line instead of carrying its own copy of the install script.How
src/1password-cli/install.shfollows 1Password's Linux install guide for Debian/Ubuntu:signed-by)1password-cli, then printsop --versionIt follows the conventions of the existing Features: it refuses to run as non-root, and it removes
curlorgpgagain if it had to install them. It has no options and installs the latest package, onamd64andarm64.The Feature README explains signing in. The desktop app's CLI integration does not reach into a container, so
opsigns in withop account addonce, theneval "$(op signin)"per terminal, and a named volume on~/.config/opkeeps the account across rebuilds.Tests
test/1password-cli/test.shchecks thatop --versionruns and thatopis at/usr/bin/op.1password-cliis added to thetest.ymlmatrix, so it is installed and tested on the Debian and Ubuntu base images.shellcheck(repo config, all optional checks) and Feature JSON validation pass.After merge
release.ymlpublishes the Feature toghcr.io/cargosense/devcontainer-features/1password-cli. A follow-up PR then switches the first consumer'sdevcontainer.jsonto it.🤖 Generated with Claude Code