Skip to content

Firefly-2165: Fix tab results resizing bug - #2060

Merged
aventura121 merged 1 commit into
rc-2026.4from
FIREFLY-2165-euclid-table-drift
Nov 9, 2026
Merged

aventura121 merged 1 commit into
rc-2026.4from
FIREFLY-2165-euclid-table-drift

Conversation

@aventura121

@aventura121 aventura121 commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

FIREFLY-2165 "euclid tables seem to slowly scootch over and/or lose the pulldown"

Description

The row currently expands to fit its tabs, and then gets resized. This means the dropdown icon button can get pushed out of view and then pulled back or dragged into view.

Fix

Set the row to take the space left over by the icon/dropdown button(s).

Builds

irsa-ife-euclid: https://firefly-2165-euclid-table-drift.irsakubedev.ipac.caltech.edu/applications/euclid

firefly: https://firefly-2165-euclid-table-drift.irsakubedev.ipac.caltech.edu/firefly

Validation

  • In the irsa-ife-euclid build, we can perform several searches for DR1 images (the targets don't matter). You may have to run 6-7 searches (or resize your browser window so the tabs and the icon need to share space).

  • Toggle between the Job Monitor and Results. Notice how the down-arrow icon button is drawn with the tabs in one pass (no drag effect).

  • We can compare this behavior to the deployment on irsa.ipac.caltech, where we see the buggy behavior of the icon dropdown button getting slowly dragged into view.

@aventura121 aventura121 self-assigned this Nov 9, 2026
@aventura121 aventura121 added the bug label Nov 9, 2026
@aventura121 aventura121 changed the title FIREFLY-2165: stop tab-width creep that hides the tab dropdown Firefly-2165: Fix tab results resizing bug Nov 9, 2026
@aventura121
aventura121 marked this pull request as ready for review November 9, 2026 18:15
@lrebull

lrebull commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

seems fixed to me!

@robyww

robyww commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

@aventura121 - this PR should be against rc-2026.4

@aventura121 aventura121 modified the milestone: 2026.4 Nov 9, 2026
@aventura121
aventura121 force-pushed the FIREFLY-2165-euclid-table-drift branch from dcc700d to 455d197 Compare November 9, 2026 18:59
@aventura121
aventura121 changed the base branch from dev to rc-2026.4 November 9, 2026 19:00
@aventura121 aventura121 added this to the 2026.4 milestone Nov 9, 2026

@kpuriIpac kpuriIpac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this fix!

@aventura121
aventura121 force-pushed the FIREFLY-2165-euclid-table-drift branch from 455d197 to 2ce9869 Compare November 9, 2026 23:06
@aventura121
aventura121 merged commit dcd0f04 into rc-2026.4 Nov 9, 2026
@aventura121
aventura121 deleted the FIREFLY-2165-euclid-table-drift branch November 9, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants