Repository navigation
Firefly-2165: Fix tab results resizing bug - #2060
Merged
Merged
Conversation
aventura121
marked this pull request as ready for review
November 9, 2026 18:15
Contributor
|
seems fixed to me! |
Contributor
|
@aventura121 - this PR should be against |
aventura121
force-pushed
the
FIREFLY-2165-euclid-table-drift
branch
from
November 9, 2026 18:59
dcc700d to
455d197
Compare
kpuriIpac
approved these changes
Nov 9, 2026
kpuriIpac
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thanks for this fix!
aventura121
force-pushed
the
FIREFLY-2165-euclid-table-drift
branch
from
November 9, 2026 23:06
455d197 to
2ce9869
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIREFLY-2165 "euclid tables seem to slowly scootch over and/or lose the pulldown"
Description
The row currently expands to fit its tabs, and then gets resized. This means the dropdown icon button can get pushed out of view and then pulled back or dragged into view.
Fix
Set the row to take the space left over by the icon/dropdown button(s).
Builds
irsa-ife-euclid: https://firefly-2165-euclid-table-drift.irsakubedev.ipac.caltech.edu/applications/euclid
firefly: https://firefly-2165-euclid-table-drift.irsakubedev.ipac.caltech.edu/firefly
Validation
In the irsa-ife-euclid build, we can perform several searches for DR1 images (the targets don't matter). You may have to run 6-7 searches (or resize your browser window so the tabs and the icon need to share space).
Toggle between the Job Monitor and Results. Notice how the down-arrow icon button is drawn with the tabs in one pass (no drag effect).
We can compare this behavior to the deployment on irsa.ipac.caltech, where we see the buggy behavior of the icon dropdown button getting slowly dragged into view.