Repository navigation
Fix(overlays): Panels stay on triggers that do not scroll with the page - #334
Open
razorfever wants to merge 6 commits into
Open
razorfever wants to merge 6 commits into
razorfever wants to merge 6 commits into
Conversation
Safari 26 places a natively anchored panel the scroll distance off when its anchor sits in a fixed or sticky box: the docs' pinned toolbar menus sank as the page scrolled, and opened that far below their trigger after a scroll. Such panels are now placed by Floating UI in every browser, decided at each open, and so is every designated trigger's panel, whose fixed-position proxy anchor is gone. The placement starts with showPopover(), before the first paint, not on the queued toggle event. The conformance suite checks for every overlay that a panel in a pinned box stays on its trigger while the page scrolls and when opened after a scroll, and that it is placed by script. The corner scenarios moved out of fixed stages so their native runs stay native. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A designated trigger whose host is `display: contents`, such as a `c-button`, has no box of its own and measured as an empty rect at 0,0, so its menu, popover or tooltip opened at the page's top-left corner. Such a reference is now measured by the union of the boxes it renders. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A modal dialog is fixed, so since the Safari 26 fix every panel opened from a form in a c-modal is placed by script, in every browser. The conformance suite now opens each overlay in a modal and scrolls the modal's content. The harness's `mount()` takes a `parent` to mount into. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for csc-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Safari 26's native anchor positioning moves a panel by the scroll distance when its trigger sits in a fixed or sticky box. Reported on iOS: the docs toolbar's menus sank as the page scrolled, and opened that far below their trigger after a scroll.
Changes
triggerprop) are always placed this way. The fixed-position proxy anchor is removed (ADR-0038 amended).c-button(anydisplay: contentshost) used to open its panel at the page's top-left corner. It now opens against the button. This bug predates the change.showPopover(), before the first paint.Tests
New conformance scenarios for every overlay tag:
c-button;c-modalwhose content scrolls.They pass on Chromium and Firefox locally. Without the fix, 21 of the pinned and designated cases fail on Chromium. WebKit runs here for the first time.
Before merging: iOS check by the reporter
Merge only once it drifts on the live site and holds on the preview. Hold Version PR #333 until this merges.
After release: when MyCSC moves to 4.0.1, check a select, an autocomplete and a date picker in a modal form while scrolling the modal, in Safari and Chrome. The docs have no modal with a field, so the preview can't cover it.
🤖 Generated with Claude Code