Skip to content

Enhances docs linting, toolbar, and tab item behavior - #332

Merged
villeerikssoncsc merged 8 commits into
mainfrom
development
Nov 20, 2026
Merged

villeerikssoncsc merged 8 commits into
mainfrom
development

Conversation

@razorfever

Copy link
Copy Markdown
Contributor

Introduces a new linting guard for documentation templates, ensuring that c-* element bindings accurately reflect the Custom Elements Manifest. This prevents silent failures caused by undeclared or removed attributes or properties.

Enhances the toolbar experience by:

  • Consolidating responsive logic for switcher menus (Color, Flavor, Theme) into a new ToolbarMenu component, which dynamically renders as a labeled button or icon-only button based on screen size.
  • Displaying the full package version in the toolbar's version badge.
  • Correcting text coloring for color names within the ColorSwitcher menu.
  • Using checked instead of active for menu items, accurately indicating the current choice.

Corrects c-tab-item behavior:

  • Prevents c-tab-item from collapsing when it carries a disabled attribute, clarifying that disabled applies to c-tab for preventing selection.
  • Adjusts c-tab-items logic to count all panels for sliding, reflecting this change.
  • Adds a dedicated test to ensure the disabled attribute on c-tab-item no longer causes unexpected collapse.

Updates planning and architectural decision records (ADRs) to document recent findings and decisions, including Android toast long-press behavior and the removal of the v3 dist-tag for 3.x releases.

razorfever and others added 8 commits November 20, 2026 08:06
npm refuses `v3` as a dist-tag name because it is a valid semver range,
and the tag is not needed: `@3` (and `@v3`) already resolve to 3.0.19,
which the READMEs pin. ADR-0028 and the release plans said 3.x keeps a
`v3` tag; they now say it needs none.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A real Android device keeps the press-and-hold pause through a long press
on toast text, the open question in ADR-0073, so the check comes off the
4.0.x follow-up list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A c-tab-item carrying a `disabled` attribute collapsed to zero width, and
c-tab-items' slide counted only the panels without one. Neither 3.x nor
4.x declared the attribute (`disabled` is the c-tab's), and a selected
panel carrying it showed nothing. Every panel now takes its slot in the
slide.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The flavour, theme and colour menus still bound 3.x's `active` on
`c-menu-item`, which 4.0 replaced with `type="radio"` and `checked`, so no
item showed as the chosen one.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It read "V4". It now names the release the site was built from, `v4.0.0`,
in lowercase so a prerelease reads `v5.0.0-alpha.1`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Below `md` the flavour, theme and colour switchers open from a
`c-icon-button`, and the flavour switcher now stays in the bar on phones,
so the pages drop their own copy of it. ToolbarMenu renders each menu twice
and CSS shows one, so the prerendered page is right before hydration.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`lint:bindings` fails when a docs template (site, canon examples, usage.md
snippets) binds an attribute or property a `c-*` element does not declare.
A custom element takes any name silently, which is how the toolbar kept
3.x's `active` through 4.0.0. Runs in `pnpm lint` and CI.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@netlify

netlify Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for csc-design-system ready!

Name Link
🔨 Latest commit 6780733
🔍 Latest deploy log https://app.netlify.com/projects/csc-design-system/deploys/6b0048957d3993229a149a83
😎 Deploy Preview https://deploy-preview-332--csc-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@villeerikssoncsc
villeerikssoncsc merged commit d572c99 into main Nov 20, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants