Repository navigation
Enhances docs linting, toolbar, and tab item behavior - #332
Merged
Merged
Conversation
npm refuses `v3` as a dist-tag name because it is a valid semver range, and the tag is not needed: `@3` (and `@v3`) already resolve to 3.0.19, which the READMEs pin. ADR-0028 and the release plans said 3.x keeps a `v3` tag; they now say it needs none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A real Android device keeps the press-and-hold pause through a long press on toast text, the open question in ADR-0073, so the check comes off the 4.0.x follow-up list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A c-tab-item carrying a `disabled` attribute collapsed to zero width, and c-tab-items' slide counted only the panels without one. Neither 3.x nor 4.x declared the attribute (`disabled` is the c-tab's), and a selected panel carrying it showed nothing. Every panel now takes its slot in the slide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The flavour, theme and colour menus still bound 3.x's `active` on `c-menu-item`, which 4.0 replaced with `type="radio"` and `checked`, so no item showed as the chosen one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It read "V4". It now names the release the site was built from, `v4.0.0`, in lowercase so a prerelease reads `v5.0.0-alpha.1`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Below `md` the flavour, theme and colour switchers open from a `c-icon-button`, and the flavour switcher now stays in the bar on phones, so the pages drop their own copy of it. ToolbarMenu renders each menu twice and CSS shows one, so the prerendered page is right before hydration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`lint:bindings` fails when a docs template (site, canon examples, usage.md snippets) binds an attribute or property a `c-*` element does not declare. A custom element takes any name silently, which is how the toolbar kept 3.x's `active` through 4.0.0. Runs in `pnpm lint` and CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for csc-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
villeerikssoncsc
approved these changes
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new linting guard for documentation templates, ensuring that
c-*element bindings accurately reflect the Custom Elements Manifest. This prevents silent failures caused by undeclared or removed attributes or properties.Enhances the toolbar experience by:
ToolbarMenucomponent, which dynamically renders as a labeled button or icon-only button based on screen size.ColorSwitchermenu.checkedinstead ofactivefor menu items, accurately indicating the current choice.Corrects
c-tab-itembehavior:c-tab-itemfrom collapsing when it carries adisabledattribute, clarifying thatdisabledapplies toc-tabfor preventing selection.c-tab-itemslogic to count all panels for sliding, reflecting this change.disabledattribute onc-tab-itemno longer causes unexpected collapse.Updates planning and architectural decision records (ADRs) to document recent findings and decisions, including Android toast long-press behavior and the removal of the
v3dist-tag for 3.x releases.