Repository navigation
Fix depot placement, Pylon power, Nuclear Silo training and invalid build types - #63
Merged
Merged
Conversation
can_build_here checked a box one tile too wide right and below, refusing most base spots once their minerals were in sight, and only saw visible units, so spots next to unseen minerals passed. It now applies BW's box (OpenBW's can_place_building) to the static minerals and geysers, skipping a mineral field seen gone. The base finder blocked one tile short (two for geysers below) and ignored blocking minerals and empty geysers, which BW counts too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7mZmXnYnfacoGvjuCRqN1
has_power_precise counted every completed Pylon, the enemy's included, so a tile beside an enemy Pylon read powered for us. BW and BWAPI power from the player's own Pylons only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G7mZmXnYnfacoGvjuCRqN1
can_train exempted Terran_Nuclear_Missile from the "cannot produce" check where BWAPI exempts Terran_Nuclear_Silo, so every Train on a silo failed with Incompatible_UnitType. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A game sent a build type outside the unit types and the bot crashed. The first such value goes to stderr with the unit, so its cause can be found. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01C1hQw9PFpN2ZatttS3djt2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four more fixes on the branch of #60. Only the four commits below are new.
can_build_herechecked a box one tile too wide to the right and below, so it refused most base spots once their minerals were in sight. It also saw only visible units, so spots next to unseen minerals passed. It now applies BW's box to the static minerals and geysers, and skips a mineral field seen gone. The base finder also blocked too few tiles and ignored blocking minerals and empty geysers. BW counts both.has_power_precisecounted every completed Pylon, including the enemy's, so a tile beside an enemy Pylon read as powered for us. Only the player's own Pylons count now.can_trainexemptedTerran_Nuclear_Missilewhere BWAPI exemptsTerran_Nuclear_Silo, so every Train on a silo failed withIncompatible_UnitType.None. The first such value goes to stderr with the unit, so its cause can be found.cargo testpasses locally.🤖 Generated with Claude Code