Repository navigation
COMP: Split OOC test discovery only in out-of-core builds - #1977
Open
imikejackson wants to merge 1 commit into
Open
imikejackson wants to merge 1 commit into
imikejackson wants to merge 1 commit into
Conversation
Every test executable ran a second Catch2 discovery for [OOC] cases. In
builds without DREAM3DNX_ENABLE_OOC, executables with no [OOC] cases
(TestOne, SimplnxReview, Synthetic, simplnx_test) printed
"contains no tests!" during the build.
simplnx_discover_tests() in cmake/DiscoverTests.cmake now registers each
executable with one discovery ("~[.]") when DREAM3DNX_ENABLE_OOC is OFF
or undefined, and keeps the split discovery with the "ooc" label when it
is ON. Every visible test is still registered exactly once.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds without out-of-core storage print a Catch2 warning for each test executable that has no
[OOC]test cases:The warning appears for
TestOneUnitTest,SimplnxReviewUnitTest,SyntheticUnitTestandsimplnx_test. It comes from the second Catch2 discovery (TEST_SPEC "[OOC]~[.]") that #1889 added to every test executable. When an executable has no[OOC]cases, that discovery finds nothing.Catch2 2.13.6 (from vcpkg) does not have
ADD_TAGS_AS_LABELS, so the change uses theDREAM3DNX_ENABLE_OOCoption instead:cmake/DiscoverTests.cmake(new) definessimplnx_discover_tests(<target>).DREAM3DNX_ENABLE_OOCis OFF or not defined (all simplnx-only builds), there is one discovery,TEST_SPEC "~[.]". Test cases tagged[OOC]are still registered, without theooclabel.DREAM3DNX_ENABLE_OOCis ON, the two discoveries stay as before, and[OOC]cases get theooclabel. This label matches the<Plugin>OocStoreContractsentries andctest -L "^ooc$".cmake/Plugin.cmake(and so the out-of-tree plugins) andtest/CMakeLists.txtcall the new function.AGENTS.mdnow says that theooclabel exists only in builds withDREAM3DNX_ENABLE_OOC=ON.Each visible test case is still registered exactly once.
In an out-of-core build, executables with no
[OOC]cases (TestOneUnitTest,simplnx_test) still print the warning. The warning does no harm.Test plan
macOS arm64, DREAM3D-NX Release builds of this branch:
DREAM3DNX_ENABLE_OOC=OFF):ctest -Nlists 4,044 tests. A build of the old discovery code from the same tree lists the same 4,044 test names.ooclabel.[OOC]-tagged TupleTransfer cases,TestOne_test_profile_isolation, and a SimplnxReview test.DREAM3DNX_ENABLE_OOC=ON, with SimplnxOocdevelop):ctest -N -L "^ooc$"lists 1,029 tests, including the 3*OocStoreContractsentries.ctest -L "^ooc$" -LE "benchmark" -j 1: 1,028 of 1,028 tests passed.🤖 Generated with Claude Code