Repository navigation
Restore visual-test coverage and enable deferred culling checks - #2092
bkaradzic-microsoft merged 6 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the Babylon.js dependency update and regression-test changes.
No open issues 🎉
1 file not reviewed
Apps/package-lock.json: Generated file
What changed in this PR
Updates BabylonNative’s Babylon.js dependencies to 9.37.1 and enables regression checks previously blocked by upstream fixes, completing the deferred culling validation from #2069.
Changes:
- Aligns application and unit-test dependencies and the shared lockfile with Babylon.js 9.37.1.
- Enables post-
setStateCullFaceTypepixel assertions and restores two Gaussian Splatting visual tests. - Narrows 18 visual-test exclusions to D3D11/D3D12 and updates FBX exclusion reasons to the remaining ChakraCore blocker.
| File | Description |
|---|---|
| Apps/UnitTests/JavaScript/src/tests.nativeEngine.defaultCulling.ts | Verifies both windings remain visible after cull-face selection. |
| Apps/UnitTests/JavaScript/package.json | Updates unit-test Babylon.js dependencies. |
| Apps/Playground/Scripts/config.json | Restores eligible visual tests and refines exclusion reasons and scope. |
| Apps/package.json | Updates application Babylon.js dependencies. |
| Apps/package-lock.json | Locks Babylon.js packages to 9.37.1 and synchronizes workspace dependencies. |
Review effort: Balanced
|
CI note (run 44337090420, attempt 1) Three jobs failed. None is caused by this PR:
The Ubuntu_Clang_JSC failure isn't related to this change. The ubuntu-26.04 runner image 20261116.202.1 ships a newer CMake that rejects a pre-existing invalid Other slow or queued jobs: MacOS_Installation queued 24m56s, then ran 5m58s; Win32_x64_V8_D3D11 queued 3m27s, then ran 34m14s (the longest job); Win32_x64_D3D11 queued 5m04s. Total wall-clock: 15:33:53Z → 16:11:41Z = 37m48s. Rerunning the failed jobs. |
|
CI: Ubuntu_Clang_JSC in run 44337090420 attempt 2 landed on the older runner image, so it got past configure. It then failed 6 of the newly re-enabled validations on Linux OpenGL (ran=731, passed=725). That's a real failure, not infra:
833c2d7 adds Fresh runs on the new ubuntu-26.04 image will still fail Ubuntu_Clang_JSC at CMake configure until #2093 merges. I'll rebase again after that. |
|
CI note (run 44356538772, attempt 1, head a3b208a) Two macOS jobs were cancelled without ever getting a runner. This is infra, not this PR:
All other jobs passed. That includes Ubuntu_Clang_JSC (queued 3s, ran 28m57s), so the OpenGL exclusions and the Other macOS jobs did get runners after long waits:
The longest job was Win32_x64_V8_D3D11: queued 3s, ran 38m16s. Total wall-clock: 17:15:04Z → 17:53:50Z = 38m46s. Rerunning the failed jobs. |
`source_group(<name> FILES ...)` doesn't accept a directory argument.
The ubuntu-26.04 runner image 20261116.202.1 ships a newer CMake, which
now rejects the stray `${CMAKE_CURRENT_SOURCE_DIR}` in
`Polyfills/Canvas/CMakeLists.txt`:
```
CMake Error at Polyfills/Canvas/CMakeLists.txt:70 (source_group):
source_group given unknown argument:
"/home/runner/work/BabylonNative/BabylonNative/Polyfills/Canvas".
```
This breaks Linux configure for any new run on that image (first seen on
#2092 Ubuntu_Clang_JSC). This PR removes the extra argument. IDE
grouping is unchanged, because the grouping comes from the group name
plus `FILES`.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
a3b208a to
f665827
Compare
f665827 to
ada9b87
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
Linux OpenGL CI (Ubuntu_Clang_JSC) fails six of the scenes re-enabled for non-D3D renderers: the FrameGraph geometry renderer scenes hit a GPU particle update effect compile failure, and the coastal cliff and Gaussian mesh scenes time out in createScene. Add OpenGL to their excludedGraphicsApis. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
…ations ChakraCore lacks ES2019 Object.fromEntries, which the Babylon.js FBX loader uses for animated files. Add it to the existing non-enumerable ES2019 polyfills in validation_native.js and re-enable the four FBX animation scenes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
Babylon.js 9.37.1 includes BabylonJS/Babylon.js#19148 and NativeEngine now supports alpha-to-coverage (BabylonJS#2082). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
Add a requiredNativeCaps config field that skips a test when any listed _native.Engine capability is false. The 18 mesh-blending, object-ID and FrameGraph geometry tests use it instead of excluding D3D11/D3D12 by name, so Vulkan devices without independent blending skip them too. Lower the shadow-attenuation tests' errorRatio to 0.5%: their enabled and disabled reference images differ by only 1.35%. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
ada9b87 to
d682efa
Compare
|
CI note (run 44429039484, attempt 1) Failed: This is infrastructure, not this PR: dependency resolution failed before any project code compiled. Android JSC and QuickJS built the same Gradle project and passed in the same run. Job timings (queue wait → run time):
Total wall-clock: 63 min. The critical path is Win32_x64_V8_D3D11 (17m queue + 46m run). Windows and macOS runners queued 9–25 min. Rerunning failed jobs. |
Summary
setStateCullFaceTypepixel expectations from NativeEngine: start with WebGL's default cull state #2069 now that Native: start with culling disabled like WebGL Babylon.js#19175 is releasedGaussian Splatting Loading RHandGaussian Splatting LODafter Native: pass view-space matrices to splat sorting Babylon.js#19182requiredNativeCaps: ["CAPS_INTEGER_COLOR_ATTACHMENTS"]after Native: support mesh blending when the runtime supports integer color attachments Babylon.js#19150 and #19151 (six of them also stay excluded on OpenGL: the FrameGraph geometry renderer scenes fail to compile the GPU particle update effect, and the coastal cliff and Gaussian mesh scenes time out in createScene on Linux CI); polyfillObject.fromEntriesfor ChakraCore invalidation_native.js(next to the existing ES2019 polyfills) and re-enable the four FBX animation scenesAlpha-to-coverage transparent overlapnow that NativeEngine: add ALPHA_REPLACE_COLOR and alpha-to-coverage #2082 is merged and Babylon.js 9.37.1 includes Native: support alpha-to-coverage Babylon.js#19148Rebased onto master after #2059, #2082 and #2093 merged.
Validation
UnitTests: 200/200 passed (JavaScript: 150 passed, 29 pending)FBX loadertests pass; without the polyfillFBX loader - skeletal animationfails withObject doesn't support property or method 'fromEntries'