Skip to content

Restore visual-test coverage and enable deferred culling checks - #2092

Merged
bkaradzic-microsoft merged 6 commits into
BabylonJS:masterfrom
bkaradzic-microsoft:bump-babylonjs-9.37.1
Nov 19, 2026
Merged

bkaradzic-microsoft merged 6 commits into
BabylonJS:masterfrom
bkaradzic-microsoft:bump-babylonjs-9.37.1

Conversation

@bkaradzic-microsoft

@bkaradzic-microsoft bkaradzic-microsoft commented Nov 18, 2026 •

Copy link
Copy Markdown
Member

Summary

Rebased onto master after #2059, #2082 and #2093 merged.

Validation

  • Win32 RelWithDebInfo UnitTests: 200/200 passed (JavaScript: 150 passed, 29 pending)
  • released-fix candidates: Gaussian Splatting Loading RH and LOD passed; alpha-to-coverage passes on Win32 Chakra D3D11 after NativeEngine: add ALPHA_REPLACE_COLOR and alpha-to-coverage #2082 (0.229% pixel difference); compound splat and FBX tests remain excluded for independent runtime blockers
  • full D3D11 Playground sweep: 757 passed, 78 failed, 57 skipped versus master baseline 752 passed, 81 failed, 59 skipped; no new failures
  • Linux OpenGL CI (Ubuntu_Clang_JSC, run 44337090420 attempt 2): 725 passed, 6 failed before those six were excluded on OpenGL
  • Win32 Chakra D3D11: all 18 FBX loader tests pass; without the polyfill FBX loader - skeletal animation fails with Object doesn't support property or method 'fromEntries'

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the Babylon.js dependency update and regression-test changes.

No open issues 🎉

1 file not reviewed
  • Apps/package-lock.json: Generated file
What changed in this PR

Updates BabylonNative’s Babylon.js dependencies to 9.37.1 and enables regression checks previously blocked by upstream fixes, completing the deferred culling validation from #2069.

Changes:

  • Aligns application and unit-test dependencies and the shared lockfile with Babylon.js 9.37.1.
  • Enables post-setStateCullFaceType pixel assertions and restores two Gaussian Splatting visual tests.
  • Narrows 18 visual-test exclusions to D3D11/D3D12 and updates FBX exclusion reasons to the remaining ChakraCore blocker.
File Description
Apps/​UnitTests/​JavaScript/​src/​tests.nativeEngine.defaultCulling.ts Verifies both windings remain visible after cull-face selection.
Apps/​UnitTests/​JavaScript/​package.json Updates unit-test Babylon.js dependencies.
Apps/​Playground/​Scripts/​config.json Restores eligible visual tests and refines exclusion reasons and scope.
Apps/​package.json Updates application Babylon.js dependencies.
Apps/​package-lock.json Locks Babylon.js packages to 9.37.1 and synchronizes workspace dependencies.

Review effort: Balanced

@bkaradzic-microsoft

Copy link
Copy Markdown
Member Author

CI note (run 44337090420, attempt 1)

Three jobs failed. None is caused by this PR:

Job Queue wait Run time Result
MacOS_Ninja / build 18m12s, never got a runner n/a cancelled (macOS runner starvation)
Android_Ubuntu_V8 / build 3s 1m12s Install NDK (Side by side) 28.2.13676358 failed with InstallFailedException (SDK download infra)
Ubuntu_Clang_JSC / build 6m55s 1m22s CMake configure error at Polyfills/Canvas/CMakeLists.txt:70 (source_group given unknown argument)

The Ubuntu_Clang_JSC failure isn't related to this change. The ubuntu-26.04 runner image 20261116.202.1 ships a newer CMake that rejects a pre-existing invalid source_group call, so it affects master too. The fix is in #2093, where Ubuntu_Clang_JSC already passes. Ubuntu_Clang_JSC will keep failing here until #2093 merges and this branch is rebased.

Other slow or queued jobs: MacOS_Installation queued 24m56s, then ran 5m58s; Win32_x64_V8_D3D11 queued 3m27s, then ran 34m14s (the longest job); Win32_x64_D3D11 queued 5m04s.

Total wall-clock: 15:33:53Z → 16:11:41Z = 37m48s.

Rerunning the failed jobs.

@bkaradzic-microsoft

Copy link
Copy Markdown
Member Author

CI: Ubuntu_Clang_JSC in run 44337090420 attempt 2 landed on the older runner image, so it got past configure. It then failed 6 of the newly re-enabled validations on Linux OpenGL (ran=731, passed=725). That's a real failure, not infra:

  • FrameGraph geometry renderer - Beauty / Normals / Geometry only / NRGE: the GPU particle update effect fails to compile on OpenGL.
  • Mesh blending - coastal cliff scenery and FrameGraph geometry renderer - Gaussian mesh: createScene doesn't resolve within 120 s.

833c2d7 adds OpenGL to these six tests' excludedGraphicsApis, with the reasons above. They still run on Metal and Vulkan. I also rebased onto master.

Fresh runs on the new ubuntu-26.04 image will still fail Ubuntu_Clang_JSC at CMake configure until #2093 merges. I'll rebase again after that.

@bkaradzic-microsoft

Copy link
Copy Markdown
Member Author

CI note (run 44356538772, attempt 1, head a3b208a)

Two macOS jobs were cancelled without ever getting a runner. This is infra, not this PR:

Job Queue wait Result
iOS_Installation / test-install 17:15:25Z → 17:36:30Z, 21m05s, no runner cancelled
MacOS_Installation / test-install 17:15:25Z → 17:37:06Z, 21m41s, no runner cancelled

All other jobs passed. That includes Ubuntu_Clang_JSC (queued 3s, ran 28m57s), so the OpenGL exclusions and the Object.fromEntries polyfill are working on Linux.

Other macOS jobs did get runners after long waits:

Job Queue wait Run time
MacOS / build 10m17s 10m33s
MacOS_Ninja / build 11m03s 5m01s
iOS_Xcode26 / build 15m06s 6m22s
iOSTests / test 5m04s 5m45s

The longest job was Win32_x64_V8_D3D11: queued 3s, ran 38m16s.

Total wall-clock: 17:15:04Z → 17:53:50Z = 38m46s.

Rerunning the failed jobs.

bkaradzic-microsoft added a commit that referenced this pull request Nov 18, 2026
`source_group(<name> FILES ...)` doesn't accept a directory argument.
The ubuntu-26.04 runner image 20261116.202.1 ships a newer CMake, which
now rejects the stray `${CMAKE_CURRENT_SOURCE_DIR}` in
`Polyfills/Canvas/CMakeLists.txt`:

```
CMake Error at Polyfills/Canvas/CMakeLists.txt:70 (source_group):
  source_group given unknown argument:
  "/home/runner/work/BabylonNative/BabylonNative/Polyfills/Canvas".
```

This breaks Linux configure for any new run on that image (first seen on
#2092 Ubuntu_Clang_JSC). This PR removes the extra argument. IDE
grouping is unchanged, because the grouping comes from the group name
plus `FILES`.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
@bkaradzic-microsoft
bkaradzic-microsoft enabled auto-merge (squash) November 18, 2026 22:26

@bghgary bghgary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Reviewed by Copilot on behalf of @bghgary]

Concerns inline.

Comment thread Apps/Playground/Scripts/config.json Resolved
Comment thread Apps/Playground/Scripts/config.json Resolved
@bghgary bghgary changed the title Bump Babylon.js to 9.37.1 and enable deferred culling checks Restore visual-test coverage and enable deferred culling checks Nov 18, 2026

@bghgary bghgary left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Reviewed by Copilot on behalf of @bghgary]

LGTM

bkaradzic-microsoft and others added 6 commits November 18, 2026 16:24
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
Linux OpenGL CI (Ubuntu_Clang_JSC) fails six of the scenes re-enabled for
non-D3D renderers: the FrameGraph geometry renderer scenes hit a GPU particle
update effect compile failure, and the coastal cliff and Gaussian mesh scenes
time out in createScene. Add OpenGL to their excludedGraphicsApis.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
…ations

ChakraCore lacks ES2019 Object.fromEntries, which the Babylon.js FBX loader
uses for animated files. Add it to the existing non-enumerable ES2019
polyfills in validation_native.js and re-enable the four FBX animation
scenes.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
Babylon.js 9.37.1 includes BabylonJS/Babylon.js#19148 and NativeEngine now
supports alpha-to-coverage (BabylonJS#2082).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
Add a requiredNativeCaps config field that skips a test when any listed
_native.Engine capability is false. The 18 mesh-blending, object-ID and
FrameGraph geometry tests use it instead of excluding D3D11/D3D12 by name,
so Vulkan devices without independent blending skip them too.

Lower the shadow-attenuation tests' errorRatio to 0.5%: their enabled and
disabled reference images differ by only 1.35%.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8bd57bfd-bbb3-4e86-8a17-9a44fb995d0f
@bkaradzic-microsoft

Copy link
Copy Markdown
Member Author

CI note (run 44429039484, attempt 1)

Failed: Android_Ubuntu_V8 / build, during Gradle configuration (3 min in). Maven Central rate-limited the runner:

Could not GET 'https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/2.2.10/kotlin-stdlib-2.2.10.pom'. Received status code 429 from server: Too Many Requests

This is infrastructure, not this PR: dependency resolution failed before any project code compiled. Android JSC and QuickJS built the same Gradle project and passed in the same run. ci-complete failed only because of this job. All 27 other jobs passed, including Win32/Linux/macOS/iOS validation.

Job timings (queue wait → run time):

Job Queue Run
Win32_x64_V8_D3D11 17m 46m
Ubuntu_Clang_JSC 0m 23m
Win32_x64_JSI_D3D11 16m 16m
Win32_x64_QuickJS_D3D11 0m 15m
MacOS 17m 11m
MacOS_QuickJS 20m 11m
iOS_Xcode26 12m 10m
UWP_arm64_JSI 16m 9m
UWP_x64_V8 9m 9m
MacOS_Ninja 4m 8m
iOS_Installation 25m 7m
UWP_arm64 14m 7m
Win32_x86_D3D11 15m 6m
MacOS_Installation 12m 5m
Win32_x64_D3D12 13m 5m
iOSTests 7m 6m
Android_Ubuntu_V8 (failed, 429) 0m 3m
Other Linux/Android/Win32 jobs 0–2m 2–9m

Total wall-clock: 63 min. The critical path is Win32_x64_V8_D3D11 (17m queue + 46m run). Windows and macOS runners queued 9–25 min.

Rerunning failed jobs.

@bkaradzic-microsoft
bkaradzic-microsoft merged commit b17a5be into BabylonJS:master Nov 19, 2026
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants