Repository navigation
Integrate Babylon React Native into the Babylon Native monorepo - #1949
Open
CedricGuillemet wants to merge 337 commits into
Open
CedricGuillemet wants to merge 337 commits into
CedricGuillemet wants to merge 337 commits into
Conversation
* fix native input usage for uwp * branch ready for native input * get app working with mouse input events * move to different submodule commits * avoid exposing device type * update content to reflect BabylonNative pr * work with babylon native changes * move to correct commit * update package references and validate uwp build * Update Modules/@babylonjs/react-native/ios/BabylonNativeInterop.mm Co-authored-by: Ryan Tremblay <ryantrem@msn.com> * Update Modules/@babylonjs/react-native/ios/BabylonNativeInterop.mm Co-authored-by: Ryan Tremblay <ryantrem@msn.com> * address review comments * try fix pr ci * move to master backslash fix Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
…abylonJS#154) * move react-native-windows content * working react-native-windows builds * rearrange git status * avoid uploading for new windows package publishing * change publish directory for windows * working windows build? * remove unused packages * add bundle step to build pr * remove unneeded bundle step * test publish * add back @babylonjs/react-native packaging * avoid checking in an installed package-lock.json for @babylonjs/react-native * confirm packaging works * add peer dependency on @babylonjs/react-native * update package lock
…ylonJS#157) * fix webxrsessionmanager propagation * address review comments
* fix webxrsessionmanager propagation * address review comments * remove unnecessary promise
* add pointer capture * add todo
…lonJS#164) * change project reference structure * update react-native-windows dependencies * make vcxproj file more legible
* complete merge * enable all UWP build flavors for pr validation and build playground * convert tasks to matrix * fix x86 directories
…bylonJS#163) * add additional items * try and decrease precompiled header size for BabylonReactNative * update pch.h definition * include header files for extension * include newer commits * fix napi-jsi build break * move openxr header into babylonreactnative repo * move back to main repo * move to newer commit * Update Package/gulpfile.js Co-authored-by: rgerd <rgerd@users.noreply.github.com> * reduce number of gulp tasks Co-authored-by: rgerd <rgerd@users.noreply.github.com>
* Update Babylon Native and update CaptureSession accordingly
…ylonJS#181) * update packages * rename folder and move off of release candidates * working playground * update peer dependencies * update packages
… tooling (BabylonJS#188) * move to most recent master * move to most recent master and rebuild cmake solutions * add conditional step for building babylonnative static libs
…abylonJS#191) * update UWP engineView to use modified graphics contract * update react-native-windows, react-native BabylonNative graphics contract * Update BabylonNative to latest commit, remove void* from BabylonNative UpdateView contract * update UWP engineView to use modified graphics contract * update react-native-windows, react-native BabylonNative graphics contract * Update BabylonNative to latest commit, remove void* from BabylonNative UpdateView contract * remove WindowType from BabylonNative.h for now * continue reverting to void*, use reinterpret_cast * Change openxr_loaderd library name, add static lib build target * Use objc++ compilation for re react-native-ios * update BabylonNative to incorporate contract changes, remove GraphicsPlatform.h include * Update Modules/@babylonjs/react-native/shared/BabylonNative.cpp Co-authored-by: Ryan Tremblay <ryantrem@msn.com> Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
…obal navigator object (BabylonJS#185) * move to custom branch * obtain xr context off of navigator * merge master into babylonnative * address review comments * move to most recent commit * move to most recent babylonnative commit
…ylonJS#195) * update babylonnative * change branch reference for now * add native anchor access * fix helper header to compile * update babylonnative * move back to correct repo reference * Update Modules/@babylonjs/react-native-windows/windows/include/XrAnchorHelperOpenXR.h Co-authored-by: Ryan Tremblay <ryantrem@msn.com> * expose ability to get native anchor Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
* Move BabylonNative build out of submodule * Update package lock checksums for local modules
…lonJS#204) * update readme * add gulp check of npm to playground install process * undo weird gulp file change * avoid gulp usage in favor of just js * avoid failing if no npm version is found * address review comments * support 6.14 npm version as well * update script comment * remove unneeded line * use npm --version instead
Bumps and [ws](https://github.com/websockets/ws). These dependencies needed to be updated together. Updates `ws` from 6.2.3 to 6.2.6 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.3...6.2.6) Updates `ws` from 7.5.10 to 7.5.13 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@6.2.3...6.2.6) --- updated-dependencies: - dependency-name: ws dependency-version: 6.2.6 dependency-type: indirect - dependency-name: ws dependency-version: 7.5.13 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependency [gulp](https://github.com/gulpjs/gulp). These dependencies need to be updated together. Updates `braces` from 2.3.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](https://github.com/micromatch/braces/commits/3.0.3) Updates `gulp` from 4.0.2 to 5.0.1 - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v4.0.2...v5.0.1) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect - dependency-name: gulp dependency-version: 5.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Fix Windows embedded source build Use the React Native Windows generated C++/WinRT projections for the CMake build and add blocking source and package CI coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Pin Windows CI to Visual Studio 2022 The windows-latest image now uses Visual Studio 2026 and no longer contains the requested 10.0.22621 SDK. Use the runner matching the v143 CMake generator and project toolset. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Support RNW new architecture on Windows Use RNW's architecture-aware C++ project integration and disable Windows App SDK transitive verification for the Playground's native module build. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Update Windows test dependencies Use the RNW patch containing the corrected Windows App SDK package and skip schema codegen for BRN's hand-written native module. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Build Windows tests against RNW NuGet Generate the Playground with explicit Fabric and NuGet settings, and protect the CMake projection path from trailing-backslash quote parsing. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Isolate Windows package build test Build the autolinked BRN project directly, keep RNW dependencies on NuGet, and avoid executable packaging during CMake compiler probes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Provide solution context to Windows tests Pass the generated solution metadata required by RNW while building only the BRN project. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Shorten Windows native build paths Place generated CMake projects under the consumer solution build directory so deeply nested MSBuild tracking files remain below MAX_PATH. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Compact Windows native build identity Keep CMake outputs below legacy MSBuild path limits while preserving platform, configuration, toolset, and generator isolation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Remove obsolete device update calls Babylon Native now performs frame synchronization in the rendering-frame methods; its DeviceUpdate compatibility shim is intentionally a no-op and deprecated. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Test Windows package with legacy architecture Generate the Windows test app through the react-native-test-app API so Fabric can be explicitly disabled while retaining the RNW NuGet dependency path. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Align Windows native C++ ABI Compile the CMake bridge as C++20, matching React Native Windows and the embedded Babylon Native dependency graph so C++/WinRT selects the same coroutine and source-location ABI. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add XR controls regression coverage Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix cross-platform Playground XR controls Keep controls visible and interactive above native engine surfaces, surface XR startup failures, and declare ARCore as an optional Android capability. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Bump braces and gulp in /Package (BabylonJS#760) Bumps [braces](https://github.com/micromatch/braces) to 3.0.3 and updates ancestor dependency [gulp](https://github.com/gulpjs/gulp). These dependencies need to be updated together. Updates `braces` from 2.3.2 to 3.0.3 - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](https://github.com/micromatch/braces/commits/3.0.3) Updates `gulp` from 4.0.2 to 5.0.1 - [Release notes](https://github.com/gulpjs/gulp/releases) - [Changelog](https://github.com/gulpjs/gulp/blob/master/CHANGELOG.md) - [Commits](gulpjs/gulp@v4.0.2...v5.0.1) --- updated-dependencies: - dependency-name: braces dependency-version: 3.0.3 dependency-type: indirect - dependency-name: gulp dependency-version: 5.0.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Address PR review feedback Preserve legacy RNW imports, validate complete Windows consumers, honor the packaged dependency lockfile, and report XR stop failures accurately. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Build Windows consumers with C++20 The full RNW solution compiles coroutine-based Hermes sources that require the same C++20 standard as the native bridge. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Fix Windows consumer project graph Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Build generated Windows app target Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Keep Windows native modules on RNW NuGet Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Configure RNW NuGet for Windows projects Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Isolate Windows consumer project builds Restore and build each autolinked project independently so MSBuild cannot traverse into React Native Windows source projects.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Force RNW NuGet mode in Windows CI Import the generated consumer setting before each C++ project evaluates its RNW references, ensuring native modules consume the matching NuGet projections and binaries.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Enforce RNW NuGet environment in CI Set the RNW NuGet properties in the MSBuild process environment and assert each native project evaluates the expected mode before restore and build.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Make RNW NuGet mode a global property Pass UseExperimentalNuget directly to every MSBuild root and reject projects that still evaluate an RNW source reference before restore.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize RNW NuGet metadata references Replace resolved Microsoft.ReactNative WinMD inputs with the consumer-selected NuGet package path before C++/WinRT generates MIDL references.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize final CppWinRT MIDL inputs Remove stale Microsoft.ReactNative metadata from every C++/WinRT reference collection immediately before generating MIDL inputs.\n\nCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Remove legacy RNW source imports in CI Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Complete RNW NuGet consumer build Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Enforce C++20 on generated Windows app Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Disable legacy coroutines for Windows app Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Work around RNTA IAsyncAction await Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Make RNTA coroutine workaround robust Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize RNW runtime package payload Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Normalize RNW PRI input snapshot Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Limit Windows CI to linked app build Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [shelljs](https://github.com/shelljs/shelljs) from 0.8.4 to 0.8.5. - [Release notes](https://github.com/shelljs/shelljs/releases) - [Changelog](https://github.com/shelljs/shelljs/blob/main/CHANGELOG.md) - [Commits](shelljs/shelljs@v0.8.4...v0.8.5) --- updated-dependencies: - dependency-name: shelljs dependency-version: 0.8.5 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Cedric Guillemet <1312968+CedricGuillemet@users.noreply.github.com>
* Update BabylonNative pin with NativeXR JSI compatibility fix Pin CedricGuillemet/BabylonNative commit ebb8a00 from draft PR #17, based on upstream 628986b. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe * Update Playground ARCore SDK to 1.56.0 Override the module default only in the Android test app and document the version. Validated the ARM64 release build and XR tracking on Pixel 9a. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe * Pin merged upstream NativeXR JSI fix Update BabylonNative to feb0227 and restore the BabylonJS archive URL after the JSI fix merged. Revalidated source preparation, TypeScript compilation, Android release build, device rendering, manually confirmed XR tracking, and suspend/resume with Playground ARCore 1.56.0. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe * Pin Playground RNW to match published NuGet packages Keep react-native-windows at the already-locked 0.81.35 so installing the packaged BabylonReactNative artifact cannot float to npm-only 0.81.37 and restore incompatible 0.82.0 NuGet binaries. Synchronize both Playground manifests and lockfiles. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 00e98a65-803d-48bb-8d36-da55ab233dfe
* Update BabylonNative to f4d9efb Pin the latest BabylonNative master revision, including the JsRuntimeHost dependency update. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 74d06f45-92ac-4835-acc2-8ed89229b9eb * Remove obsolete minz links for updated BabylonNative Update iOS and Windows consumers after BabylonNative stopped producing the minz library; refresh the iOS podspec checksum. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 74d06f45-92ac-4835-acc2-8ed89229b9eb --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 74d06f45-92ac-4835-acc2-8ed89229b9eb
* docs: synchronize READMEs with 2.0.6 and current build setup Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d68c500-a3eb-4b2e-8726-17b7f4073d8f * docs: use Babylon Native workspace for iOS Playground Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d68c500-a3eb-4b2e-8726-17b7f4073d8f * docs: record resolved Playground version baselines Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d68c500-a3eb-4b2e-8726-17b7f4073d8f * docs: update READMEs for 2.0.7 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d68c500-a3eb-4b2e-8726-17b7f4073d8f --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8d68c500-a3eb-4b2e-8726-17b7f4073d8f
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Packaged builds remain disconnected through the shared native wrapper. Local Gradle configuration accepts the change and reaches dependency fetching; full local Android configuration is blocked by the SDK Ninja Windows path limit. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Keep upstream Hermes nightly jobs and publication gating inside the BabylonNative stage, retaining the ReactNative stage unchanged. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
* Pin Babylon Native fork NativeXr EndFrame fix Use CedricGuillemet/BabylonNative nativexr-endframe-fix at b85d4f0 for staging package builds. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06586ce7-bc10-46c1-83b5-3334fc60600d * Pin merged Babylon Native EndFrame fix Use upstream BabylonNative commit 37d30f5, the merged fix from BabylonJS#1957. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06586ce7-bc10-46c1-83b5-3334fc60600d * Document 2.0.8 preview and merged NativeXr fix Keep 2.0.7 identified as the latest stable release, document the 2.0.8 preview source pin and unchanged compatibility baselines, and leave release version assignment to the existing publishing workflow. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06586ce7-bc10-46c1-83b5-3334fc60600d * Prepare READMEs for stable 2.0.8 release Replace preview-target framing with planned stable 2.0.8 release notes, preserving the tested Babylon Native pin and compatibility baselines without claiming publication. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06586ce7-bc10-46c1-83b5-3334fc60600d * Document 2.0.8 as the current stable release Update installation guidance and compatibility tables for released 2.0.8, removing release-preparation wording while preserving the tested Babylon Native pin and compatibility baselines. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06586ce7-bc10-46c1-83b5-3334fc60600d * Remove 2.0.8 bug-fix descriptions from READMEs Keep the current release, installation, compatibility and source-pin tables while removing NativeXr fix descriptions and bug PR links. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06586ce7-bc10-46c1-83b5-3334fc60600d --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 06586ce7-bc10-46c1-83b5-3334fc60600d
Preserve upstream native nightly jobs and the React Native stage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Retain the monorepo source layout while adopting upstream release documentation. Stage the new bgfx child dependencies and V8 inspector dependencies for offline package builds. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Use in-tree bgfx, JsRuntimeHost and UrlLib library outputs in Windows and iOS consumers. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
CedricGuillemet
requested review from
bghgary and
ryantrem
and
a balanced review from Copilot
October 29, 2026 08:38
CedricGuillemet
marked this pull request as ready for review
October 29, 2026 08:38
Retain Babylon.js attribution while removing the duplicate React Native license and stale package output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: baba94fb-c4c7-4db1-b40e-0f96acd08f31
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved critical defects include native build failures, import-time crashes, a cross-thread initialization data race, and Windows view and worker-thread leaks.
11 open issues
Guard mediaDevices callback when NativeCamera is unavailable · New Load TTF fonts as binary data · New Conditionally reference optional plugin CMake targets · New Synchronize lifecycle flag across rendering threads · New Avoid linking unsupported NativeXr on Windows · New Preserve nativeXr receiver for getNativeAnchor · New Stop input worker during EngineView unload · New Add source-checkout fallback for React Native lookup · New Emit numeric preprocessor value for NativeCamera option · New Release all pointers on ACTION_CANCEL · New Pass inverse transparency to TextureView setOpaque · New
1 file not reviewed
Embedding/ReactNative/Apps/Playground/ios/BRNPlayground.xcworkspace/contents.xcworkspacedata: Generated file
What changed in this PR
Integrates Babylon React Native into the Babylon Native monorepo, bringing its module, Playground, native bindings, and packaging workflows into the same checkout.
Changes:
- Imports the React Native API, shared JSI runtime integration, and Android/iOS/Windows bindings.
- Supports checkout-based development and disconnected native sources in published packages.
- Adds platform and packaged-consumer CI, release/preview publishing, and temporary main-CI wiring.
Paths below use RN/ for Embedding/ReactNative/, Module/ for its Modules/@babylonjs/react-native/ directory, and Playground/ for its Apps/Playground/ directory.
| File | Description |
|---|---|
| README.md | Updated as part of this pull request. |
| Embedding/ReactNative/SECURITY.md | Updated as part of this pull request. |
| Embedding/ReactNative/Package/setup_dev.js | Updated as part of this pull request. |
| Embedding/ReactNative/Package/package.json | Updated as part of this pull request. |
| Embedding/ReactNative/Package/.gitignore | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/CMakeLists.txt | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/resource.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/ReactPackageProvider.idl | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/ReactPackageProvider.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/ReactPackageProvider.cpp | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/PropertySheet.props | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/pch.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/pch.cpp | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/EngineViewManager.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/EngineViewManager.cpp | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/EngineView.idl | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/EngineView.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/EngineView.cpp | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/BabylonReactNative.vcxproj.filters | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/BabylonReactNative.rc | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/BabylonReactNative.def | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/BabylonModule.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/BabylonReactNative/BabylonModule.cpp | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/windows/.gitignore | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/VersionValidation.ts | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/tsconfig.json | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/shared/XrContextHelper.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/shared/XrAnchorHelper.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/shared/DispatchFunction.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/shared/CMakeLists.txt | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/shared/BabylonNative/CMakeLists.txt | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/shared/BabylonNative.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/shared/BabylonNative.cpp | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/ReactNativeEngine.ts | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/react-native-babylon.podspec | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/postinstall.js | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/package.json | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/NativeEngineView.tsx | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/NativeEngineHook.ts | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/NativeCapture.ts | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/jest.config.js | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/ios/EngineViewManager.mm | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/ios/CMakeLists.txt | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/ios/BabylonNativeInterop.mm | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/ios/BabylonNativeInterop.h | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/ios/BabylonModule.mm | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/index.ts | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/FontFace.ts | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/EngineView.tsx | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/EngineHook.ts | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/BabylonModule.ts | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/src/main/java/com/babylonreactnative/SnapshotDataReturnedEvent.java | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/src/main/java/com/babylonreactnative/EngineViewManager.java | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/src/main/java/com/babylonreactnative/EngineView.java | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/src/main/java/com/babylonreactnative/BabylonPackage.java | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/src/main/java/com/babylonreactnative/BabylonNativeInterop.java | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/src/main/java/com/babylonreactnative/BabylonModule.java | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/src/main/cpp/BabylonNativeInterop.cpp | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/src/main/AndroidManifest.xml | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/README.md | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/ReactBabylonNative.cpp | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/CMakeLists.txt | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/android/.gitignore | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/.npmignore | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/.gitignore | Updated as part of this pull request. |
| Embedding/ReactNative/Modules/@babylonjs/react-native/.gitattributes | Updated as part of this pull request. |
| Embedding/ReactNative/LICENSE | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/windows/ReactNativeNuGet.targets | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/windows/.gitignore | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/README.md | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/react-native.config.js | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/package.json | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/package-windows.json | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/metro.config.js | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/macos/Podfile | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/jest.config.js | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/ios/Podfile | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/ios/BRNPlayground.xcworkspace/contents.xcworkspacedata | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/index.js | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/generate-windows-test-app.mjs | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/babel.config.js | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/App.tsx | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/app.json | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/android/settings.gradle | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/android/gradlew.bat | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/android/gradlew | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/android/gradle/wrapper/gradle-wrapper.properties | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/android/gradle.properties | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/android/build.gradle | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/.watchmanconfig | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/.gitignore | Updated as part of this pull request. |
| Embedding/ReactNative/Apps/Playground/__tests__/App.test.tsx | Updated as part of this pull request. |
| Embedding/ReactNative/.gitignore | Updated as part of this pull request. |
| Dependencies/JsRuntimeHost/CMakeLists.txt | Updated as part of this pull request. |
| .github/workflows/reactnative-windows.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-typescript.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-test-windows.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-test-ios.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-test-android.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-publish.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-publish-preview.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-pr.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-package.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-ios.yml | Updated as part of this pull request. |
| .github/workflows/reactnative-android.yml | Updated as part of this pull request. |
| .github/workflows/ci.yml | Updated as part of this pull request. |
Review effort: Balanced
| // Override the navigator.mediaDevices.getUserMedia to insert a camera permissions request. It would be cleaner to do this directly in the NativeCamera implementation, but there are a couple problems with that: | ||
| // 1. React Native does not provide a way to hook into the permissions request result (at least on Android). | ||
| // 2. If it is done on the native side, then we need one implementation per platform. | ||
| { |
| try { | ||
| this._status = "loading"; | ||
| if (typeof this.source === 'string') { | ||
| this.source = await Tools.LoadFileAsync(this.source); |
Comment on lines
+268
to
+269
| PRIVATE $<TARGET_PROPERTY:NativeCamera,INCLUDE_DIRECTORIES> | ||
| PRIVATE $<TARGET_PROPERTY:NativeXr,INCLUDE_DIRECTORIES> |
| std::shared_ptr<bool> m_isXRActive{}; | ||
| uint8_t mMSAAValue{}; | ||
| bool mAlphaPremultiplied{}; | ||
| bool m_newEngine{}; |
| if (${BABYLON_NATIVE_PLUGIN_NATIVECAMERA}) | ||
| list(APPEND ADDITIONAL_LIBRARIES NativeCamera) | ||
| endif() | ||
| if (${BABYLON_NATIVE_PLUGIN_NATIVEXR}) |
| trueThis->_revokerData.PointerMovedRevoker = trueThis->_inputSource.PointerMoved(winrt::auto_revoke, { trueThis.get(), &EngineView::OnPointerMoved }); | ||
| trueThis->_revokerData.PointerReleasedRevoker = trueThis->_inputSource.PointerReleased(winrt::auto_revoke, { trueThis.get(), &EngineView::OnPointerReleased }); | ||
|
|
||
| trueThis->_inputSource.Dispatcher().ProcessEvents(Windows::UI::Core::CoreProcessEventsOption::ProcessUntilQuit); |
Comment on lines
+32
to
+33
| if(EXISTS "${PLAYGROUND_DIR}/react-native/package.json") | ||
| get_filename_component(REACTNATIVE_DIR_CMAKE "${PLAYGROUND_DIR}/react-native" ABSOLUTE) |
| add_library(BabylonNative ${SHARED_SOURCES}) | ||
|
|
||
| target_compile_definitions(BabylonNative PRIVATE BABYLON_NATIVE_PLUGIN_NATIVEXR=${BABYLON_NATIVE_PLUGIN_NATIVEXR}) | ||
| target_compile_definitions(BabylonNative PRIVATE BABYLON_NATIVE_PLUGIN_NATIVECAMERA=${BABYLON_NATIVE_PLUGIN_NATIVECAMERA}) |
| boolean isPointerUp = maskedAction == MotionEvent.ACTION_UP || maskedAction == MotionEvent.ACTION_POINTER_UP; | ||
| boolean isPointerMove = maskedAction == MotionEvent.ACTION_MOVE; | ||
|
|
||
| if (isPointerDown || isPointerUp) { |
| this.transparentTextureView = new TextureView(this.getContext()); | ||
| this.transparentTextureView.setLayoutParams(EngineView.childViewLayoutParams); | ||
| this.transparentTextureView.setSurfaceTextureListener(this); | ||
| this.transparentTextureView.setOpaque(isTransparent); |
Preserve the staged nightly pipeline and apply upstream disk cleanup to its Hermes jobs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
bghgary
marked this pull request as draft
November 9, 2026 21:23
Contributor
|
[Commented by Copilot on behalf of @bghgary] Moving this to draft while we wait for Cedric’s updates. |
CedricGuillemet
marked this pull request as ready for review
November 10, 2026 08:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


React Native contributors can develop and release against Babylon Native in the same checkout instead of downloading a separately pinned native source archive. This brings BabylonReactNative into
Embedding/ReactNative, preserving its Git history and the Playground name. The imported history includes BabylonReactNative master through5177b5db(2.0.8), and the branch incorporates BabylonNative master through0d768704b.Development builds use the enclosing native checkout, including when the module is installed locally through npm. Published packages retain the disconnected
Repo/depslayout and existing binary-library paths. Assembly copies the required native sources without recursively including React Native. Packaging accommodates the upstream vendored JsRuntimeHost/UrlLib layout, separate bx/bimg/bgfx source trees, and V8 inspector dependencies required for offline configuration. Windows and iOS consumers use the corresponding in-tree library output paths.Platform source builds and packaged-consumer builds run through flat
.github/workflows/reactnative-*.ymlworkflows. Azure nightly adds a ReactNative stage while retaining upstream native jobs and publication gating; upstream sanitizer coverage remains innightly-extended.yml. Releases taggedreact-native/vX.Y.Zpublish npm versionX.Y.Z, and a separate workflow supports preview publishing.Temporary wiring: remove before merge. Main
ci.ymlunconditionally callsreactnative-pr.ymlto exercise this PR, marked# TEMPORARY: remove before mergeand included in the aggregate check. The path-filtered entry avoids duplicate runs while this call exists and resumes direct execution once it is removed.Worth a look:
.githuband.vscode; no imported tags are pushed. The upstream 2.0.8 README updates are retained, but its obsolete native commit pin is intentionally not restored.Embedding/ReactNative/LICENSEis removed. Packages use the rootLICENSE.md, retain the original Babylon.js copyright in their README, and remove stale duplicate license output during incremental assembly.NPM_TOKENsecret with permission to publish@babylonjs/react-native. Azure nightly and npm publication have not been executed; packaged FetchContent configuration was checked locally, but NuGet still contacted vulnerability metadata, so this was not a fully network-isolated test.Babylon::Embeddingremain out of scope.