Repository navigation
Build the Docker image for release tags - #2712
Merged
Merged
Conversation
A workflow_run branches filter never matches a run triggered by a tag push, so build-docker.yml never started for 4.5.14 or 4.5.15. check_ref already limits builds to dev and to a release tag on its own commit.
Contributor
Author
|
Friendly ping on this one. 4.5.15 is out on PyPI, but It's a one-line trigger fix: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
4.5.14 and 4.5.15 are on PyPI, but
acockburn/appdaemonhas no image for either (the latest is 4.5.13).Since f32fb19, a release tag runs Python CI, then
pypi-upload.ymlandbuild-docker.ymlviaworkflow_run. For both tags, Python CI succeeded (b24a31e, a731c39) and PyPI published, butbuild-docker.ymlhas no run at all for those commits. Dev pushes still build.The difference is the trigger:
build-docker.ymlhasbranches: ['**'],pypi-upload.ymlhas none. A branch filter doesn't match a tag-triggered run, so GitHub never starts the workflow for releases.This drops the filter.
check_refalready limits builds todevand to a release tag on its own commit, and only forpush-triggered CI runs, so PR CI still builds nothing.Once merged, re-running the 4.5.15 tag's Python CI (or re-pushing the tag) should publish its image.