Skip to content

Build the Docker image for release tags - #2712

Merged
acockburn merged 1 commit into
AppDaemon:devfrom
tmilnthorp:fix/docker-release-tags
Nov 13, 2026
Merged

acockburn merged 1 commit into
AppDaemon:devfrom
tmilnthorp:fix/docker-release-tags

Conversation

@tmilnthorp

Copy link
Copy Markdown
Contributor

4.5.14 and 4.5.15 are on PyPI, but acockburn/appdaemon has no image for either (the latest is 4.5.13).

Since f32fb19, a release tag runs Python CI, then pypi-upload.yml and build-docker.yml via workflow_run. For both tags, Python CI succeeded (b24a31e, a731c39) and PyPI published, but build-docker.yml has no run at all for those commits. Dev pushes still build.

The difference is the trigger: build-docker.yml has branches: ['**'], pypi-upload.yml has none. A branch filter doesn't match a tag-triggered run, so GitHub never starts the workflow for releases.

This drops the filter. check_ref already limits builds to dev and to a release tag on its own commit, and only for push-triggered CI runs, so PR CI still builds nothing.

Once merged, re-running the 4.5.15 tag's Python CI (or re-pushing the tag) should publish its image.

A workflow_run branches filter never matches a run triggered by a tag push,
so build-docker.yml never started for 4.5.14 or 4.5.15. check_ref already
limits builds to dev and to a release tag on its own commit.
@tmilnthorp

Copy link
Copy Markdown
Contributor Author

Friendly ping on this one. 4.5.15 is out on PyPI, but acockburn/appdaemon:4.5.15 (and :4.5.14) still don't exist, so anyone pinning the Docker image is stuck on 4.5.13.

It's a one-line trigger fix: the branches filter means tag-triggered CI runs never start build-docker.yml. Once merged, re-running the 4.5.15 tag's Python CI should publish the image. Happy to adjust anything if you'd prefer a different approach. Thanks!

@acockburn
acockburn merged commit 69873e6 into AppDaemon:dev Nov 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants