Repository navigation
Fix the 4.5.14 release builds: ARM Docker image and PyPI upload - #2694
Merged
Merged
Conversation
- Dockerfile: on ARM, uvloop is built from source (there are no musllinux armv6/armv7 wheels), and the libuv bundled with uvloop 0.23.0 needs the kernel headers (`linux/errqueue.h`). Add `linux-headers` to the ARM build dependencies. - pypi-upload.yml: install the locked test dependencies into a project environment before installing the wheel, as python.yml does. `uv pip install` had no virtual environment to install into, so the job failed before running the functional tests or publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 4.5.14 tag's Docker and PyPI runs both failed, so 4.5.14 has no image and no PyPI release. Two fixes:
Docker (arm/v7, arm/v6):
uvloop==0.23.0(bumped in 5ce30c8 "Update deps") fails to compile withsrc/unix/udp.c:36:10: fatal error: linux/errqueue.h: No such file or directory.linux-headersto the ARM build dependencies.linux-headers, and produces a wheel with it.PyPI upload:
uv pip install dist/*.whlfails with "No virtual environment found".v*tags.uv sync --locked --no-install-project --no-editable --no-dev --group test) before installing the wheel.uv run pytest -m functionalpass (23 passed).After merging, a re-run of the 4.5.14 workflows, or a new tag, should publish the image and the PyPI release.