Repository navigation
fix(ci): azure: keep SAS URLs out of the public run logs - #383
Merged
Merged
Conversation
The Azure Marketplace release and the HPC image upload printed working SAS URLs into the run logs, which are public for this repository: - azure-hpc-to-storage-container.yml pasted the base64-encoded Blob SAS URL input into the script text, which the log prints; masking only covered the decoded URL, and base64 is no protection. - azure-to-marketplace.yml and the azure-marketplace-steps action (regular Azure releases) stored the new container SAS (read + list, 8 days) in GITHUB_ENV unmasked, so every later step listed it, and the configure step pasted it into its script text. - Both also dumped the product resource tree, technical configuration and configure payload, which carry the SAS URI of every VM image version already in the offer. Now: - The HPC upload reads the input from the event payload and masks the encoded URL, the decoded URL and its signature (as is and URL-decoded) before anything else. It also fails early, without printing the value, when the decoded input is not a Blob SAS URL. - The release masks the storage account key, the new SAS token and its signature right after creating them, and reads SAS_URI from the environment instead of an expression. - Right after fetching the resource tree, the release masks the signature of every SAS URI in it, which covers all the later dumps. Also correct the stale "60 days" SAS expiry comment (it is 8 days) and document the masking.
andrewlukoshko
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Azure Marketplace release and the HPC image upload printed working SAS URLs into the run logs, which are public for this repository:
azure-hpc-to-storage-container.ymlpasted the base64-encoded Blob SAS URL input into the script text, which the log prints; masking only covered the decoded URL, and base64 is no protection.azure-to-marketplace.ymland theazure-marketplace-stepsaction (regular Azure releases) stored the new container SAS (read + list, 8 days) inGITHUB_ENVunmasked, so every later step listed it, and the configure step pasted it into its script text.Now:
Also correct the stale "60 days" SAS expiry comment (it is 8 days) and document the masking.