Skip to content

[PWGCF] Clean up math functions in femto frame work - #18542

Merged
ariedel-cern merged 3 commits into
AliceO2Group:masterfrom
ariedel-cern:master
Nov 1, 2026
Merged

ariedel-cern merged 3 commits into
AliceO2Group:masterfrom
ariedel-cern:master

Conversation

@ariedel-cern

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgcf label Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@ariedel-cern
ariedel-cern marked this pull request as ready for review November 1, 2026 21:46
@ariedel-cern
ariedel-cern enabled auto-merge (squash) November 1, 2026 21:46
alibuild
alibuild previously approved these changes Nov 1, 2026

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@alibuild

alibuild commented Nov 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 01e6d3f at 2026-11-01 22:56:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 1 warnings.'
Found 4 errors and 1 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/6dbe697e390e0607ff16092e64298254ee47d6d6/O2Physics-code-check/errors.txt
PWGCF/Femto/Core/femtoMath.h:161:25: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Core/pairHistManager.h:34:1: error: included header Vector3Dfwd.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Core/pairHistManager.h:40:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto/Core/tripletHistManager.h:32:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/6dbe697e390e0607ff16092e64298254ee47d6d6/O2Physics-code-check/warnings.txt
PWGCF/Femto/Core/tripletHistManager.h:850:55: warning: 1st argument 'part2' (passed to 'part1') looks like it might be swapped with the 2nd, 'part3' (passed to 'part2') [readability-suspicious-call-argument]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@ariedel-cern
ariedel-cern disabled auto-merge November 1, 2026 22:27

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @ariedel-cern.

@ariedel-cern
ariedel-cern merged commit efd7340 into AliceO2Group:master Nov 1, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants