Skip to content

[PWGDQ] handle track-collision reassociation in alignment QA task - #18536

Open
aferrero2707 wants to merge 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-handle-collision-reassociation
Open

aferrero2707 wants to merge 1 commit into
AliceO2Group:masterfrom
aferrero2707:PWGDQ-global-alignment-handle-collision-reassociation

Conversation

@aferrero2707

Copy link
Copy Markdown
Contributor
  • add proper handling of ambiguous tracks with multiple compatible collisions, and output the ambiguous associations in the derived tables.
  • improve selection of dimuon candidates to be stored in the derived tables, adding a minimum mass cut as well as specific momentum and pT cuts.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 77 warnings, 🔕 10 disabled

@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-handle-collision-reassociation branch 2 times, most recently from 0dc3245 to e453f8e Compare October 31, 2026 09:26
@aferrero2707
aferrero2707 marked this pull request as ready for review October 31, 2026 10:09
@alibuild

alibuild commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for e453f8e at 2026-10-31 12:09:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/muonGlobalAlignment.cxx:2484:55: error: comparison of integer expressions of different signedness: 'int32_t' {aka 'int'} and 'std::vector<std::unique_ptr<std::vector<int> > >::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Oct 31, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for e453f8e at 2026-10-31 11:31:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for e453f8e at 2026-10-31 12:06:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/muonGlobalAlignment.cxx:2484:55: error: comparison of integer expressions of different signedness: 'int32_t' {aka 'int'} and 'std::vector<std::unique_ptr<std::vector<int> > >::size_type' {aka 'long unsigned int'} [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

- add proper handling of ambiguous tracks with multiple compatible
  collisions, and output the ambiguous associations in the derived
  tables.
- improve selection of dimuon candidates to be stored in the derived
  tables, adding a minimum mass cut as well as specific momentum
  and pT cuts.
@aferrero2707
aferrero2707 force-pushed the PWGDQ-global-alignment-handle-collision-reassociation branch from e453f8e to 83a5d50 Compare October 31, 2026 11:09
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 83a5d50 at 2026-10-31 12:21:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 1 warnings.'
Found 2 errors and 1 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/4626d4ecb6799f362a033150a2a367354e19e999/O2Physics-code-check/errors.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:24:1: error: included header FwdTrackReAlignTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/muonGlobalAlignment.cxx:660:45: error: C-style casts are discouraged; use static_cast/const_cast/reinterpret_cast [google-readability-casting,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/4626d4ecb6799f362a033150a2a367354e19e999/O2Physics-code-check/warnings.txt
PWGDQ/Tasks/muonGlobalAlignment.cxx:278:9: warning: macro 'PROCESS_DERIVED_TABLES' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants