Skip to content

[PWGCF] add particle histograms and 2p correlation 2D profile - #18533

Merged
abilandz merged 4 commits into
AliceO2Group:masterfrom
pykuan:master
Oct 31, 2026
Merged

abilandz merged 4 commits into
AliceO2Group:masterfrom
pykuan:master

Conversation

@pykuan

@pykuan pykuan commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor
  • add DCAXY, DCAZ and eta histograms for cut checks
  • add 2p correlation 2D profile to study its nTracks dependency (3p and 4p will be added in the next PR)

@github-actions github-actions Bot added the pwgcf label Oct 30, 2026
@github-actions github-actions Bot changed the title add particle histograms and 2p correlation 2D profile [PWGCF] add particle histograms and 2p correlation 2D profile Oct 30, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for bf00290 at 2026-10-31 01:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 0 warnings.'
Found 3 errors and 0 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/a3b851b97f87cb306a5b5496a15f74ddc698febf/O2Physics-code-check/errors.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:447:16: error: no header providing "TProfile2D" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:1857:23: error: redundant explicit casting to the same type 'int' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:1861:7: error: Value stored to 'nBinsXMult' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 7209042 at 2026-10-31 02:41:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 0 warnings.'
Found 2 errors and 0 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/8687354aa643f15ec8d467dcccdd1002556a69e0/O2Physics-code-check/errors.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:447:16: error: no header providing "TProfile2D" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCumulants.cxx:1857:23: error: redundant explicit casting to the same type 'int' as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

@abilandz abilandz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is approved now, please fix the remaining last 2 errors from code-checker alongside the next PR. Thanks!

@abilandz
abilandz merged commit b9fefcf into AliceO2Group:master Oct 31, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants