Skip to content

[PWGDQ] Setup prompt non prompt separation table - #18527

Merged
axti98 merged 7 commits into
AliceO2Group:masterfrom
JonathanWitte:separatePromptNonPromptTable
Oct 31, 2026
Merged

axti98 merged 7 commits into
AliceO2Group:masterfrom
JonathanWitte:separatePromptNonPromptTable

Conversation

@JonathanWitte

Copy link
Copy Markdown
Contributor

Adding more variables for prompt non prompt separation
Calculating this variables in the var Manager
Fill the table in dq Efficiency and dq tableReader with assoc
Move the table filling out of the cut loop

@github-actions github-actions Bot added the pwgdq label Oct 30, 2026
@github-actions github-actions Bot changed the title Setup prompt non prompt separation table [PWGDQ] Setup prompt non prompt separation table Oct 30, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1323 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 55571a9 at 2026-10-30 18:14:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 20 errors and 22 warnings.'
Found 20 errors and 22 warnings.
++ [[ 20 -gt 0 ]]
++ cat /sw/BUILD/cce08a0511ff72827a191e36db06bbd42c4b663b/O2Physics-code-check/errors.txt
PWGDQ/Core/VarManager.h:1917:34: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3155:73: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3158:72: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3161:71: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3161:111: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3168:75: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3171:79: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3171:130: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3171:181: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3174:79: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3174:130: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3174:181: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3283:75: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3289:68: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3290:66: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3291:69: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3292:73: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Core/VarManager.h:3293:68: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
PWGDQ/Tasks/dqEfficiency_withAssoc.cxx:2260:36: error: C-style casts are discouraged; use constructor call syntax [google-readability-casting,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.h:1921:38: error: C-style casts are discouraged; use constructor call syntax [google-readability-casting,-warnings-as-errors]
++ [[ 22 -gt 0 ]]
++ cat /sw/BUILD/cce08a0511ff72827a191e36db06bbd42c4b663b/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.cxx:52:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:53:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:55:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:67:1: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.cxx:93:28: warning: initializer for base class 'TObject' is redundant [readability-redundant-member-init]
PWGDQ/Core/VarManager.cxx:147:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:309:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:416:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:483:5: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/VarManager.cxx:2997:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.cxx:3007:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.cxx:3008:9: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
PWGDQ/Core/VarManager.h:1256:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1257:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
[0 more errors; see full log]

Full log here.

@axti98
axti98 merged commit aed5e53 into AliceO2Group:master Oct 31, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants