Skip to content

[PWGDQ] Reset and fill the event properties in the runMCGen - #18523

Merged
axti98 merged 1 commit into
AliceO2Group:masterfrom
JonathanWitte:correctedMCeventProperties
Oct 30, 2026
Merged

axti98 merged 1 commit into
AliceO2Group:masterfrom
JonathanWitte:correctedMCeventProperties

Conversation

@JonathanWitte

Copy link
Copy Markdown
Contributor

In the runMCGen, the Event variables are never filled in the VarManager. Therefore, the event properties like CentFT0C remain from the last reconstructed event, which leads to confusing/ unphysical distributions

@github-actions github-actions Bot added the pwgdq label Oct 30, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 261 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Reset and fill the event properties in the runMCGen [PWGDQ] Reset and fill the event properties in the runMCGen Oct 30, 2026
@JonathanWitte
JonathanWitte marked this pull request as ready for review October 30, 2026 13:19
@axti98
axti98 enabled auto-merge (squash) October 30, 2026 13:35
@axti98
axti98 merged commit c3d6182 into AliceO2Group:master Oct 30, 2026
13 of 15 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 8646f4e at 2026-10-30 20:47:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 0 warnings.'
Found 1 errors and 0 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/e4c57dc3721ea2f67c52409b0d7aa8533881a60b/O2Physics-code-check/errors.txt
PWGDQ/Tasks/dqEfficiency_withAssoc.cxx:2235:36: error: C-style casts are discouraged; use constructor call syntax [google-readability-casting,-warnings-as-errors]
++ [[ 0 -gt 0 ]]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants