Skip to content

[PWGCF] Add internal validation and new cuts - #18522

Merged
abilandz merged 4 commits into
AliceO2Group:masterfrom
meiALICE:master
Oct 30, 2026
Merged

abilandz merged 4 commits into
AliceO2Group:masterfrom
meiALICE:master

Conversation

@meiALICE

Copy link
Copy Markdown
Contributor

Add internal validation for verifying Q-vector calculations.

Add additional experimental particle cuts.

Add numContrib hist.

Simplification of naming of some variable.

@github-actions github-actions Bot added the pwgcf label Oct 30, 2026
@github-actions github-actions Bot changed the title Add internal validation and new cuts [PWGCF] Add internal validation and new cuts Oct 30, 2026
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ccadc27 at 2026-10-30 12:24:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 3 warnings.'
Found 2 errors and 3 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/c618939f4eee3fe2cac4467211b6d226a9b574cd/O2Physics-code-check/errors.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:363:15: error: no header providing "std::size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:984:54: error: no header providing "TMath::TwoPi" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/c618939f4eee3fe2cac4467211b6d226a9b574cd/O2Physics-code-check/warnings.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:272:45: warning: initializer for member 'fEventCutSwitch' is redundant [readability-redundant-member-init]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:275:48: warning: initializer for member 'fParticleCutSwitch' is redundant [readability-redundant-member-init]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsMei.cxx:282:36: warning: initializer for member 'fIVHarmonics' is redundant [readability-redundant-member-init]
++ [[ 2 -gt 0 ]]
++ exit 1
--

Full log here.

} misc;

struct InternalValidation {
TRandom3* randGen = new TRandom3(1);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have here new TRandom3(1); and not new TRandom3(0);? Only if you use the latter, ROOT ensures that the seed for random generation is unique in time and space.

@meiALICE meiALICE Oct 30, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because initially I want to ensure that the seed is the same for each time I run it, just like in MC studies. But I didn't think too much for hyperloop case...

I have changed it to 0. Thank you very much for the correction!

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not now, but in the next PR you could add a configurable option for this argument to cover both use cases.

@abilandz abilandz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please replace quickly new TRandom3(1); with new TRandom3(0)- that's relvant if you want to redo this validation study in Hyperloop.

@abilandz
abilandz enabled auto-merge (squash) October 30, 2026 14:09
@abilandz
abilandz merged commit d7fbcbf into AliceO2Group:master Oct 30, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants