Skip to content

[PWGCF] Add charged differential flow for qa and resolve time association ownership - #18521

Merged
wenyaCern merged 1 commit into
AliceO2Group:masterfrom
huinaibing:charged-time-association-differential-flow
Oct 30, 2026
Merged

wenyaCern merged 1 commit into
AliceO2Group:masterfrom
huinaibing:charged-time-association-differential-flow

Conversation

@huinaibing

Copy link
Copy Markdown
Contributor

Lock PV contributors to their original collision and assign non-PV tracks to the closest time-compatible collision using BC-corrected time differences. Remove the raw-candidate uniqueness option and update association QA.

Add a charged-only differential v2{2}(pT) process with independent reference pT cuts and POI binning, sharing the time-associated table used by integrated flow, NUA and NUE. Group runtime state to respect the task reflection member limit.

Validation: changed-range clang-format checks, git diff --check, static ownership checks and numerical examples. No compilation performed.

Lock PV contributors to their original collision and assign non-PV tracks to the closest time-compatible collision using BC-corrected time differences. Remove the raw-candidate uniqueness option and update association QA.

Add a charged-only differential v2{2}(pT) process with independent reference pT cuts and POI binning, sharing the time-associated table used by integrated flow, NUA and NUE. Group runtime state to respect the task reflection member limit.

Validation: changed-range clang-format checks, git diff --check, static ownership checks and numerical examples. No compilation performed.
@github-actions github-actions Bot added the pwgcf label Oct 30, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 25 warnings, 🔕 0 disabled

@wenyaCern
wenyaCern merged commit e1b125c into AliceO2Group:master Oct 30, 2026
12 of 14 checks passed
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0a7d633 at 2026-10-30 14:30:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 1 warnings.'
Found 4 errors and 1 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/be70aa397eb12f396cfa06d1d866a580f34a8eb3/O2Physics-code-check/errors.txt
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:568:33: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:576:65: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:604:96: error: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting,-warnings-as-errors]
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:897:92: error: C-style casts are discouraged; use static_cast [google-readability-casting,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/be70aa397eb12f396cfa06d1d866a580f34a8eb3/O2Physics-code-check/warnings.txt
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx:3844:13: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants