Skip to content

[PWGUD] updates to upcRhoAnalysis - #18520

Open
jjuracka wants to merge 19 commits into
AliceO2Group:masterfrom
jjuracka:upc-rho-analysis-update
Open

jjuracka wants to merge 19 commits into
AliceO2Group:masterfrom
jjuracka:upc-rho-analysis-update

Conversation

@jjuracka

Copy link
Copy Markdown
Contributor

This PR comprises several updates to the upcRhoAnalysis task.
These include minor changes of default values for configurable parametres and histogram definitions (axis specs or adding new histograms), but also extensions of derived data, and the addition of a new process function.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 2 warnings, 🔕 0 disabled

@alibuild

alibuild commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5c1a767 at 2026-10-31 12:45:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 2 errors and 87 warnings.'
Found 2 errors and 87 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/290b169f068ac8db3d3fbc5730cdefe2f752f5ea/O2Physics-code-check/errors.txt
PWGUD/Tasks/upcRhoAnalysis.cxx:843:31: error: the variable 'p1' is copy-constructed from a const reference but is only used as const reference; consider making it a const reference [performance-unnecessary-copy-initialization,-warnings-as-errors]
PWGUD/Tasks/upcRhoAnalysis.cxx:950:7: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
++ [[ 87 -gt 0 ]]
++ cat /sw/BUILD/290b169f068ac8db3d3fbc5730cdefe2f752f5ea/O2Physics-code-check/warnings.txt
PWGUD/Tasks/upcRhoAnalysis.cxx:223:15: warning: member 'pcEtaCut' of type 'const float' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
PWGUD/Tasks/upcRhoAnalysis.cxx:224:13: warning: member 'nExpectedPions' of type 'const int' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
PWGUD/Tasks/upcRhoAnalysis.cxx:225:26: warning: member 'runNumbers' of type 'const std::vector<int>' is const qualified [cppcoreguidelines-avoid-const-or-ref-data-members]
PWGUD/Tasks/upcRhoAnalysis.cxx:331:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:383:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:471:65: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:499:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoAnalysis.cxx:500:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoAnalysis.cxx:501:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGUD/Tasks/upcRhoAnalysis.cxx:614:55: warning: repeated branch body in conditional chain [bugprone-branch-clone]
PWGUD/Tasks/upcRhoAnalysis.cxx:616:9: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGUD/Tasks/upcRhoAnalysis.cxx:644:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:649:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:655:30: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:660:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:665:59: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:671:64: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:678:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:685:54: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:701:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:706:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:711:47: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:716:46: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:721:53: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:726:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:731:93: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:736:100: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:741:69: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:746:147: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:751:37: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:756:125: warning: statement should be inside braces [readability-braces-around-statements]
PWGUD/Tasks/upcRhoAnalysis.cxx:761:70: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants