Repository navigation
[PWGDQ] Update table with properties for prompt-non prompt J/psi separation - #18370
JonathanWitte wants to merge 7 commits into
Conversation
… add FT0C centrality value, and setup stable filling outside the cut loop
|
O2 linter results: ❌ 0 errors, |
| @@ -2293,10 +2375,6 @@ struct AnalysisSameEventPairing { | |||
| } | |||
| } | |||
| if (sign1 * sign2 < 0) { | |||
There was a problem hiding this comment.
Why introduce the check above again if it is already here?
There was a problem hiding this comment.
This is in the loop over the cut sets, so the table would be filled multiple times. Also t1&t2 are not available here
| values[kDCAxy2] = dca2XY; | ||
| values[kDCAz2] = dca2Z; | ||
|
|
||
| values[kDCASigxy1] = dca1XY / std::sqrt(t1.cYY()); |
There was a problem hiding this comment.
The calculations are done already a few lines below, maybe you can move the definitions below out of the if-condition so it is only calculated once and then add the kDCASig variables. But good notice that they never have been filled
| values[kVertexingLz] = std::sqrt(values[kVertexingLz]); | ||
| values[kVertexingLxyz] = std::sqrt(values[kVertexingLxyz]); | ||
|
|
||
| values[kVertexingLxyOverErr] = values[kVertexingLxy] / values[kVertexingLxyErr]; |
There was a problem hiding this comment.
These are already calculated below, around line 5191 (old), respectively 5207 (with your current changes)
| kCharge1, | ||
| kDCAxy1, | ||
| kDCAz1, | ||
| kDCASigxy1, // DCAxy / sqrt(cYY) of leg 1 |
There was a problem hiding this comment.
Please rename the variable to kDCAxyOverSig1 or (or similar) instead of leaving a comment here. Nobody notices that comment.
In general, please always name variables to exactly what the do and do not put a comment.
| fgVarNamesMap["kCharge1"] = kCharge1; | ||
| fgVarNamesMap["kDCAxy1"] = kDCAxy1; | ||
| fgVarNamesMap["kDCAz1"] = kDCAz1; | ||
| fgVarNamesMap["kDCASigxy1"] = kDCASigxy1; |
There was a problem hiding this comment.
Also here, rename to kDCAxyOverSig1 and also for the second leg (as commented in the VarManager.h)
| } | ||
| } | ||
| } | ||
| // flat table for prompt / non-prompt BDT training: one row per MC-matched opposite-sign pair |
There was a problem hiding this comment.
Remove the comments here, not necessary
| (fConfigML.applyBDT && fOutputMlPsi2ee.size() > 1) ? VarManager::fgValues[VarManager::kBdtPrompt] : -999.f, | ||
| (fConfigML.applyBDT && fOutputMlPsi2ee.size() > 2) ? VarManager::fgValues[VarManager::kBdtNonprompt] : -999.f); | ||
| } | ||
| // flat table for prompt / non-prompt BDT training: one row per pair (not per cut; select cuts offline via PairFilter) |
There was a problem hiding this comment.
Remove the comments also here, not necessary
Please consider the following formatting changes to AliceO2Group#18370
Thorough review and upgrade of the table used for P/NP separation
PromptNonPromptSepTable / o2::aod::JPsieeCandidates / "DQPSEUDOPROPER"
Recalculating missing properties
Removing TPC track quality properties due to MC mismatch
Add FT0C centrality in table
Move table fill outside of cut loop and guard missing options with condition