Repository navigation
Conversation
Follow-up to AliceO2Group#16019, from a review of the reader: - Refuse leaves with fLen <= 0, which ROOT never writes. A corrupt length of 0 produced columns of N rows over an empty buffer. - Read TBasket headers forwards, as TBasket::Streamer writes them, in one helper used by the container, the object reader and the decoder. Baskets written with TTree::kGenerateOffsetMap store a negative fNevBufSize followed by one fIOBits byte; reading a fixed 19-byte tail backwards from fKeylen misread them, so such valid files were rejected as corrupt. - Check that the baskets of a size branch cover its fEntries before allocating the offsets from it. - In auto mode fall back to ROOT on any exception from the native reader, not only on FormatError, and map any per-DF exception to an invalid timeframe. A DF number longer than 19 digits is refused as corrupt data instead of escaping as std::out_of_range. Tested with a new decoder test for baskets with fIOBits, the AODNative unit tests (34 cases), the framework root, aod-native and analysis-support tests, and the native-vs-ROOT comparison on a production AO2D (264 DFs, 792 trees, byte-identical).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #16019, from a review of the reader:
of 0 produced columns of N rows over an empty buffer.
helper used by the container, the object reader and the decoder. Baskets
written with TTree::kGenerateOffsetMap store a negative fNevBufSize
followed by one fIOBits byte; reading a fixed 19-byte tail backwards from
fKeylen misread them, so such valid files were rejected as corrupt.
allocating the offsets from it.
not only on FormatError, and map any per-DF exception to an invalid
timeframe. A DF number longer than 19 digits is refused as corrupt data
instead of escaping as std::out_of_range.
Tested with a new decoder test for baskets with fIOBits, the AODNative unit
tests (34 cases), the framework root, aod-native and analysis-support tests,
and the native-vs-ROOT comparison on a production AO2D (264 DFs, 792 trees,
byte-identical).