Repository navigation
TPC SCD: fix getDXI off-by-one for row 127 - #16030
Merged
shahor02 merged 1 commit intoNov 1, 2026
Merged
Conversation
Row 127 (the first row of OROC3, NRowsAccumulated[2] = 127) failed the check ix > NRowsAccumulated[NROCTypes - 2] and fell through to the OROC2 branch, so it got the OROC2 pad height (1/1.2 cm^-1 instead of 1/1.5 cm^-1). This affects the x-kernel width of TrackResiduals::getSmoothEstimate when the closest voxel is in row 127, and the x mean-position validity check in TPCFastSpaceChargeCorrectionHelper for that row. Only non-uniform (per pad row) x-binning is affected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
November 1, 2026 20:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row 127 (the first row of OROC3, NRowsAccumulated[2] = 127) failed the check ix > NRowsAccumulated[NROCTypes - 2] and fell through to the OROC2 branch, so it got the OROC2 pad height (1/1.2 cm^-1 instead of 1/1.5 cm^-1). This affects the x-kernel width of TrackResiduals::getSmoothEstimate when the closest voxel is in row 127, and the x mean-position validity check in TPCFastSpaceChargeCorrectionHelper for that row. Only non-uniform (per pad row) x-binning is affected.