Repository navigation
TPC: createFromLocalCorrection with irregular spline knots - #16028
Open
matthias-kleiner wants to merge 1 commit into
Open
matthias-kleiner wants to merge 1 commit into
matthias-kleiner wants to merge 1 commit into
Conversation
New overload of TPCFastSpaceChargeCorrectionHelper::createFromLocalCorrection taking the knot positions in y and z as vectors, so a correction from a continuous function can have dense knots where it changes fast (e.g. at the sector edges). The knots are rounded to an integer grid with 1/10 of the smallest knot distance as step, as in createFromTrackResiduals; the first and the last knot are put at the ends of the grid (row y edges; central electrode and readout in z). The function is sampled at 6 points per knot interval over the whole grid. The existing uniform version is unchanged. It samples y only between the outermost pad centres, so the outer half pad of each row is extrapolated by the spline. Test with a B = 0 cosmics correction map (spline - map, rms in dx / dy / dz): - 10 x 10 uniform knots: new overload 61 / 42 / 43 um, existing function 60 / 49 / 42 um; within 6 % of the row width of the sector edges dy 41 um (1.7 mm max) vs 218 um (3.9 mm max). - 20 x 10 uniform knots: new overload 59 / 38 / 39 um; existing function 0.5 / 2.1 / 1.0 mm, up to 16 cm on the pad range and 36 cm at the sector edges. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
matthias-kleiner
requested review from
davidrohr,
shahor02 and
wiechula
as code owners
October 31, 2026 21:48
shahor02
approved these changes
Oct 31, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New overload of TPCFastSpaceChargeCorrectionHelper::createFromLocalCorrection taking the knot positions in y and z as vectors, so a correction from a continuous function can have dense knots where it changes fast (e.g. at the sector edges). The knots are rounded to an integer grid with 1/10 of the smallest knot distance as step, as in createFromTrackResiduals; the first and the last knot are put at the ends of the grid (row y edges; central electrode and readout in z). The function is sampled at 6 points per knot interval over the whole grid.
The existing uniform version is unchanged. It samples y only between the outermost pad centres, so the outer half pad of each row is extrapolated by the spline. Test with a B = 0 cosmics correction map (spline - map, rms in dx / dy / dz):