Repository navigation
Amend #3072 DELETE without WHERE on IndexedDB - #3078
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up #3072 by @shaktimaan00, which fixed #1217.
#3072 sends
DELETE FROM twithout WHERE to the engine'sdeleteFromTable, which is what fixes IndexedDB. It also limited theloadTableDataandsaveTableDatacalls to LOCALSTORAGE and FILESTORAGE by name. That part is not needed for the fix, as IndexedDB returns before reaching those calls, and it broke an engine registered by the user that defines both methods.This restores the original conditions for the branch without WHERE and keeps the delegation. The WHERE branch is unchanged.
In
test/test1217.jsthe stub no longer returns a count, as the real IndexedDB engine returns nothing and passes the count to the callback, so the test now checks the callback. A new test covers an engine registered by the user, and it fails without the change.