Repository navigation
Amend #3071 CREATE LOCALSTORAGE with a missing index record - #3077
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up #3071 by @abhi478jeetur-rgb, which fixed #3070.
After #3071,
CREATE LOCALSTORAGE DATABASEtook any localStorage key with the same name as an existing database. If an app keeps JSON under that key,CREATE LOCALSTORAGE DATABASE IF NOT EXISTS settingsadopted it and the nextCREATE TABLE settings.tthrew a TypeError.Now a record counts as a database only when it has the shape of one, with
databaseidandtables, and only when the index record does not list the database. When the index lists it, the code takes the same path as before #3071, without rewriting the index record.test/test3070.jsnow also checks thatIF NOT EXISTSreturns 0 when it repairs the index, and that a key of another app is not taken as a database. The new test fails without the change.