Repository navigation
Do not reuse a join index keyed on a parameter to close #3075 - #3076
Merged
mathiasrw merged 3 commits intoNov 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3075
preIndexcaches the join index on the table under a hash ofonrightfns+srcwherefns. When that expression readsparams[...], the cached index only matches the values of the first run, so a later run with other values reuses it and returns wrong rows.Now an index whose key expression reads a parameter is built for the run and is neither looked up nor stored on the table. Indexes without parameters are still cached as before.
test/test3075.jscovers a positional?and a named$dinJOIN ... ON, a?in aFROM s, w WHEREjoin condition, and checks that a parameter-free index is still reused. The three parameter cases fail ondevelopand pass with the change.Full suite (bun, Windows): 2636 pass, 9 fail. The same 9 fail on
developwithout the change (Excelsourcefilenametests in 107-B and two piped-input CLI tests).